You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/05/06 15:38:33 UTC
[GitHub] flink pull request: [FLINK-3879] [gelly] Native implementation of ...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1967
[FLINK-3879] [gelly] Native implementation of HITS algorithm
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3879_native_implementation_of_hits_algorithm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1967
----
commit 724a86b5b5e7e7a93392048d5842fe54df7c4bfe
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-05-06T15:13:26Z
[FLINK-3879] [gelly] Native implementation of HITS algorithm
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #1967: [FLINK-3879] [gelly] Native implementation of HITS algori...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the issue:
https://github.com/apache/flink/pull/1967
Hey @greghogan,
was there consensus regarding this change? I see the numbers, but did anyone review this PR?
I've been offline for the past few days, and I now see that nobody reviewed #2160, #2079, #2067, #1997 either...
I don't doubt that you have done a great job, but it is _always_ better to let someone review your code before you merge. We don't usually merge PRs without a +1 unless it is something trivial. I understand things move faster this way, but we are in a community and we should try to collaborate.
Please, leave a comment next time you think a PR has stayed with no review for a long time or ping me personally if you want a 2nd pair of eyes on gelly stuff :)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #1967: [FLINK-3879] [gelly] Native implementation of HITS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1967
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---