You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/11/17 16:40:22 UTC

svn commit: r1883546 - in /pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox: pdmodel/interactive/form/ pdmodel/interactive/pagenavigation/ text/ util/

Author: lehmi
Date: Tue Nov 17 16:40:22 2020
New Revision: 1883546

URL: http://svn.apache.org/viewvc?rev=1883546&view=rev
Log:
PDFBOX-5017: sonar fix

Removed:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/package.html
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/package.html
Modified:
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AcroFormsRotationTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AlignmentTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/HandleDifferentDALevelsTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/MultilineFieldsTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFlattenTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionDirectionTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/MatrixTest.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestDateUtil.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestHexUtil.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestNumberFormatUtil.java
    pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestQuickSort.java

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AcroFormsRotationTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AcroFormsRotationTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AcroFormsRotationTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AcroFormsRotationTest.java Tue Nov 17 16:40:22 2020
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class AcroFormsRotationTest
+class AcroFormsRotationTest
 {
 
     private static final File OUT_DIR = new File("target/test-output");
@@ -48,7 +48,7 @@ public class AcroFormsRotationTest
     }
 
     @Test
-    public void fillFields() throws IOException
+    void fillFields() throws IOException
     {
 
         // portrait page

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AlignmentTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AlignmentTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AlignmentTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/AlignmentTest.java Tue Nov 17 16:40:22 2020
@@ -26,7 +26,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class AlignmentTest
+class AlignmentTest
 {
     private static final File OUT_DIR = new File("target/test-output");
     private static final File IN_DIR = new File("src/test/resources/org/apache/pdfbox/pdmodel/interactive/form");
@@ -46,7 +46,7 @@ public class AlignmentTest
     }
 
     @Test
-    public void fillFields() throws IOException
+    void fillFields() throws IOException
     {
         PDTextField field = (PDTextField) acroForm.getField("AlignLeft");
         field.setValue(TEST_VALUE);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/ControlCharacterTest.java Tue Nov 17 16:40:22 2020
@@ -21,7 +21,6 @@ import static org.junit.jupiter.api.Asse
 
 import java.io.File;
 import java.io.IOException;
-import java.util.ArrayList;
 import java.util.List;
 import java.util.stream.Collectors;
 
@@ -59,7 +58,8 @@ import org.junit.jupiter.api.Test;
  * @see <a href="https://issues.apache.org/jira/browse/PDFBOX-3461">https://issues.apache.org/jira/browse/PDFBOX-3461</a>
  * 
  */
-public class ControlCharacterTest {
+class ControlCharacterTest
+{
     private static final File IN_DIR = new File("src/test/resources/org/apache/pdfbox/pdmodel/interactive/form");
     private static final String NAME_OF_PDF = "ControlCharacters.pdf";
 
@@ -74,7 +74,7 @@ public class ControlCharacterTest {
     }
     
     @Test
-    public void characterNUL() throws IOException
+    void characterNUL() throws IOException
     {
         assertThrows(IllegalArgumentException.class, () -> {
             acroForm.getField("pdfbox-nul").setValue("NUL\0NUL");
@@ -82,13 +82,13 @@ public class ControlCharacterTest {
     }
 
     @Test
-    public void characterTAB() throws IOException
+    void characterTAB() throws IOException
     {
     	acroForm.getField("pdfbox-tab").setValue("TAB\tTAB");
     }
     
     @Test
-    public void characterSPACE() throws IOException
+    void characterSPACE() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-space");
     	field.setValue("SPACE SPACE");
@@ -100,7 +100,7 @@ public class ControlCharacterTest {
     }
 
     @Test
-    public void characterCR() throws IOException
+    void characterCR() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-cr");
     	field.setValue("CR\rCR");
@@ -112,7 +112,7 @@ public class ControlCharacterTest {
     }
 
     @Test
-    public void characterLF() throws IOException
+    void characterLF() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-lf");
     	field.setValue("LF\nLF");
@@ -124,7 +124,7 @@ public class ControlCharacterTest {
     }
     
     @Test
-    public void characterCRLF() throws IOException
+    void characterCRLF() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-crlf");
     	field.setValue("CRLF\r\nCRLF");
@@ -136,7 +136,7 @@ public class ControlCharacterTest {
     }
 
     @Test
-    public void characterLFCR() throws IOException
+    void characterLFCR() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-lfcr");
     	field.setValue("LFCR\n\rLFCR");
@@ -148,7 +148,7 @@ public class ControlCharacterTest {
     }
     
     @Test
-    public void characterUnicodeLinebreak() throws IOException
+    void characterUnicodeLinebreak() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-linebreak");
     	field.setValue("linebreak\u2028linebreak");
@@ -160,7 +160,7 @@ public class ControlCharacterTest {
     }
     
     @Test
-    public void characterUnicodeParagraphbreak() throws IOException
+    void characterUnicodeParagraphbreak() throws IOException
     {
     	PDField field = acroForm.getField("pdfbox-paragraphbreak");
     	field.setValue("paragraphbreak\u2029paragraphbreak");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/HandleDifferentDALevelsTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/HandleDifferentDALevelsTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/HandleDifferentDALevelsTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/HandleDifferentDALevelsTest.java Tue Nov 17 16:40:22 2020
@@ -30,7 +30,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class HandleDifferentDALevelsTest
+class HandleDifferentDALevelsTest
 {
     private static final File OUT_DIR = new File("target/test-output");
     private static final File IN_DIR = new File("src/test/resources/org/apache/pdfbox/pdmodel/interactive/form");
@@ -62,7 +62,7 @@ public class HandleDifferentDALevelsTest
     }
 
     @Test
-    public void checkSingleAnnotation() throws IOException
+    void checkSingleAnnotation() throws IOException
     {
         PDTextField field = (PDTextField) acroForm.getField("SingleAnnotation");
         String fieldFontSetting = getFontSettingFromDA(field);
@@ -75,7 +75,7 @@ public class HandleDifferentDALevelsTest
     }
     
     @Test
-    public void checkSameLayout() throws IOException
+    void checkSameLayout() throws IOException
     {
         PDTextField field = (PDTextField) acroForm.getField("MultipeAnnotations-SameLayout");
         String fieldFontSetting = getFontSettingFromDA(field);
@@ -89,7 +89,7 @@ public class HandleDifferentDALevelsTest
     
     // TODO: enable the test after issue 3687 has been fixed
     @Test
-    public void checkDifferentLayout() throws IOException
+    void checkDifferentLayout() throws IOException
     {
         PDTextField field = (PDTextField) acroForm.getField("MultipleAnnotations-DifferentLayout");
         String fieldFontSetting = getFontSettingFromDA(field);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/MultilineFieldsTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/MultilineFieldsTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/MultilineFieldsTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/MultilineFieldsTest.java Tue Nov 17 16:40:22 2020
@@ -36,7 +36,7 @@ import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class MultilineFieldsTest
+class MultilineFieldsTest
 {
     private static final File OUT_DIR = new File("target/test-output");
     private static final File IN_DIR = new File("src/test/resources/org/apache/pdfbox/pdmodel/interactive/form");
@@ -57,7 +57,7 @@ public class MultilineFieldsTest
     }
 
     @Test
-    public void fillFields() throws IOException
+    void fillFields() throws IOException
     {
         PDTextField field = (PDTextField) acroForm.getField("AlignLeft");
         field.setValue(TEST_VALUE);
@@ -108,7 +108,7 @@ public class MultilineFieldsTest
 
     // Test for PDFBOX-3812
     @Test
-    public void testMultilineAuto() throws IOException
+    void testMultilineAuto() throws IOException
     {
         PDDocument document = Loader.loadPDF(new File(IN_DIR, "PDFBOX3812-acrobat-multiline-auto.pdf"));
         PDAcroForm acroForm = document.getDocumentCatalog().getAcroForm();
@@ -139,7 +139,7 @@ public class MultilineFieldsTest
 
     // Test for PDFBOX-3835
     @Test
-    public void testMultilineBreak() throws IOException
+    void testMultilineBreak() throws IOException
     {
         final String TEST_PDF = "PDFBOX-3835-input-acrobat-wrap.pdf";
         PDDocument document = Loader.loadPDF(new File(IN_DIR, TEST_PDF));

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFlattenTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFlattenTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFlattenTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFlattenTest.java Tue Nov 17 16:40:22 2020
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test;
  * as the test results need manual inspection. Enable as needed.
  *
  */
-public class PDAcroFormFlattenTest
+class PDAcroFormFlattenTest
 {
 
     private static final File IN_DIR = new File("target/test-output/flatten/in");
@@ -93,7 +93,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX2469Empty() throws IOException
+    void testFlattenPDFBOX2469Empty() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12682897/FormI-9-English.pdf";
         String targetFileName = "FormI-9-English.pdf";
@@ -107,7 +107,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX2469Filled() throws IOException
+    void testFlattenPDFBOX2469Filled() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12678455/testPDF_acroForm.pdf";
         String targetFileName = "testPDF_acroForm.pdf";
@@ -121,7 +121,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX2586() throws IOException
+    void testFlattenPDFBOX2586() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12689788/test.pdf";
         String targetFileName = "test-2586.pdf";
@@ -150,7 +150,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX3262() throws IOException
+    void testFlattenPDFBOX3262() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12792007/hidden_fields.pdf";
         String targetFileName = "hidden_fields.pdf";
@@ -164,7 +164,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX3396_1() throws IOException
+    void testFlattenPDFBOX3396_1() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12816014/Signed-Document-1.pdf";
         String targetFileName = "Signed-Document-1.pdf";
@@ -178,7 +178,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX3396_2() throws IOException
+    void testFlattenPDFBOX3396_2() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12816016/Signed-Document-2.pdf";
         String targetFileName = "Signed-Document-2.pdf";
@@ -192,7 +192,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX3396_3() throws IOException
+    void testFlattenPDFBOX3396_3() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12821307/Signed-Document-3.pdf";
         String targetFileName = "Signed-Document-3.pdf";
@@ -206,7 +206,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBOX3396_4() throws IOException
+    void testFlattenPDFBOX3396_4() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12821308/Signed-Document-4.pdf";
         String targetFileName = "Signed-Document-4.pdf";
@@ -296,7 +296,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBox4693() throws IOException
+    void testFlattenPDFBox4693() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12986337/stenotypeTest-3_rotate_no_flatten.pdf";
         String targetFileName = "PDFBOX-4693-filled.pdf";
@@ -311,7 +311,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException
      */
     @Test
-    public void testFlattenPDFBox4788() throws IOException
+    void testFlattenPDFBox4788() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12994791/flatten.pdf";
         String targetFileName = "PDFBOX-4788.pdf";
@@ -325,7 +325,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException 
      */
     @Test
-    public void testFlattenPDFBox4889() throws IOException
+    void testFlattenPDFBox4889() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13005793/f1040sb%20test.pdf";
         String targetFileName = "PDFBOX-4889.pdf";
@@ -339,7 +339,7 @@ public class PDAcroFormFlattenTest
      * @throws IOException 
      */
     @Test
-    public void testFlattenPDFBox4955() throws IOException
+    void testFlattenPDFBox4955() throws IOException
     {
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13011410/PDFBOX-4955.pdf";
         String targetFileName = "PDFBOX-4955.pdf";

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormFromAnnotsTest.java Tue Nov 17 16:40:22 2020
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
  * Tests for building AcroForm entries form Widget annotations.
  *
  */
-public class PDAcroFormFromAnnotsTest
+class PDAcroFormFromAnnotsTest
 {
     /**
      * PDFBOX-4985 AcroForms entry but empty Fields array 
@@ -51,7 +51,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots4985DefaultMode() throws IOException
+    void testFromAnnots4985DefaultMode() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13013354/POPPLER-806.pdf";
@@ -86,7 +86,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots4985CorrectionMode() throws IOException
+    void testFromAnnots4985CorrectionMode() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13013354/POPPLER-806.pdf";
@@ -121,7 +121,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots4985WithoutCorrectionMode() throws IOException
+    void testFromAnnots4985WithoutCorrectionMode() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/13013354/POPPLER-806.pdf";
@@ -149,7 +149,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots3891DontCreateFields() throws IOException
+    void testFromAnnots3891DontCreateFields() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12881055/merge-test.pdf";
@@ -174,7 +174,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots3891CreateFields() throws IOException
+    void testFromAnnots3891CreateFields() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12881055/merge-test.pdf";
@@ -229,7 +229,7 @@ public class PDAcroFormFromAnnotsTest
      * @throws IOException
      */
     @Test
-    public void testFromAnnots3891ValidateFont() throws IOException
+    void testFromAnnots3891ValidateFont() throws IOException
     {
 
         String sourceUrl = "https://issues.apache.org/jira/secure/attachment/12881055/merge-test.pdf";

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroFormTest.java Tue Nov 17 16:40:22 2020
@@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDButton class.
  *
  */
-public class PDAcroFormTest
+class PDAcroFormTest
 {
     
     private PDDocument document;
@@ -68,7 +68,7 @@ public class PDAcroFormTest
     }
 
     @Test
-    public void testFieldsEntry()
+    void testFieldsEntry()
     {
         // the /Fields entry has been created with the AcroForm
         // as this is a required entry
@@ -91,7 +91,7 @@ public class PDAcroFormTest
     }
     
     @Test
-    public void testAcroFormProperties()
+    void testAcroFormProperties()
     {
         assertTrue(acroForm.getDefaultAppearance().isEmpty());
         acroForm.setDefaultAppearance("/Helv 0 Tf 0 g");
@@ -99,7 +99,7 @@ public class PDAcroFormTest
     }
     
     @Test
-    public void testFlatten() throws IOException
+    void testFlatten() throws IOException
     {
         File file = new File(OUT_DIR, "AlignmentTests-flattened.pdf");
         try (PDDocument testPdf = Loader.loadPDF(new File(IN_DIR, "AlignmentTests.pdf")))
@@ -124,7 +124,7 @@ public class PDAcroFormTest
      * (PDFBOX-3301)
      */
     @Test
-    public void testFlattenWidgetNoRef() throws IOException
+    void testFlattenWidgetNoRef() throws IOException
     {
         File file = new File(OUT_DIR, "AlignmentTests-flattened-noRef.pdf");
 
@@ -154,7 +154,7 @@ public class PDAcroFormTest
     }
     
     @Test
-    public void testFlattenSpecificFieldsOnly() throws IOException
+    void testFlattenSpecificFieldsOnly() throws IOException
     {
         File file = new File(OUT_DIR, "AlignmentTests-flattened-specificFields.pdf");
         
@@ -188,7 +188,7 @@ public class PDAcroFormTest
      * (PDFBOX-3752)
      */
     @Test
-    public void testDontAddMissingInformationOnDocumentLoad()
+    void testDontAddMissingInformationOnDocumentLoad()
     {
         try
         {
@@ -220,7 +220,7 @@ public class PDAcroFormTest
      * (PDFBOX-3752)
      */
     @Test
-    public void testAddMissingInformationOnAcroFormAccess()
+    void testAddMissingInformationOnAcroFormAccess()
     {
         try
         {
@@ -259,7 +259,7 @@ public class PDAcroFormTest
      * @throws IOException 
      */
     @Test
-    public void testBadDA() throws IOException
+    void testBadDA() throws IOException
     {
         try (PDDocument doc = new PDDocument())
         {
@@ -302,7 +302,7 @@ public class PDAcroFormTest
      * they don't exist.
      */
     @Test
-    public void testAcroFormDefaultFonts() throws IOException
+    void testAcroFormDefaultFonts() throws IOException
     {
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
         try (PDDocument doc = new PDDocument())

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDButtonTest.java Tue Nov 17 16:40:22 2020
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDButton class.
  *
  */
-public class PDButtonTest
+class PDButtonTest
 {
     
     
@@ -70,7 +70,7 @@ public class PDButtonTest
     }
 
     @Test
-    public void createCheckBox()
+    void createCheckBox()
     {
         PDButton buttonField = new PDCheckBox(acroForm);
         
@@ -81,7 +81,7 @@ public class PDButtonTest
     }
 
     @Test
-    public void createPushButton()
+    void createPushButton()
     {
         PDButton buttonField = new PDPushButton(acroForm);
         
@@ -92,7 +92,7 @@ public class PDButtonTest
     }
 
     @Test
-    public void createRadioButton()
+    void createRadioButton()
     {
         PDButton buttonField = new PDRadioButton(acroForm);
         
@@ -102,7 +102,6 @@ public class PDButtonTest
         assertFalse(buttonField.isPushButton());
     }
     
-    @Test
     /**
      * PDFBOX-3656
      * 
@@ -112,7 +111,8 @@ public class PDButtonTest
      * 
      * @throws IOException
      */
-    public void testRadioButtonWithOptions() throws MalformedURLException
+    @Test
+    void testRadioButtonWithOptions() throws MalformedURLException
     {
         File file = new File(TARGET_PDF_DIR, "PDFBOX-3656.pdf");
         
@@ -133,7 +133,6 @@ public class PDButtonTest
         }
     }
     
-    @Test
     /**
      * PDFBOX-3682
      * 
@@ -143,7 +142,8 @@ public class PDButtonTest
      * 
      * @throws IOException
      */
-    public void testOptionsAndNamesNotNumbers() throws MalformedURLException
+    @Test
+    void testOptionsAndNamesNotNumbers() throws MalformedURLException
     {
         File file = new File(TARGET_PDF_DIR, "PDFBOX-3682.pdf");
         try (InputStream is = new FileInputStream(file);
@@ -154,12 +154,16 @@ public class PDButtonTest
             radioButton.setValue("c");
 
             // test that the old behavior is now invalid
-            assertNotEquals("This shall no longer be 2", "2", radioButton.getValueAsString());
-            assertNotEquals("This shall no longer be 2", "2", radioButton.getWidgets().get(2).getCOSObject().getNameAsString(COSName.AS));
+            assertNotEquals("2", radioButton.getValueAsString(), "This shall no longer be 2");
+            assertNotEquals("2",
+                    radioButton.getWidgets().get(2).getCOSObject().getNameAsString(COSName.AS),
+                    "This shall no longer be 2");
             
             // test for the correct behavior
-            assertEquals("This shall be c", "c", radioButton.getValueAsString());
-            assertEquals("This shall be c", "c", radioButton.getWidgets().get(2).getCOSObject().getNameAsString(COSName.AS));
+            assertEquals("c", radioButton.getValueAsString(), "This shall be c");
+            assertEquals("c",
+                    radioButton.getWidgets().get(2).getCOSObject().getNameAsString(COSName.AS),
+                    "This shall be c");
         }
         catch (IOException e)
         {
@@ -168,7 +172,7 @@ public class PDButtonTest
     }
         
     @Test
-    public void retrieveAcrobatCheckBoxProperties()
+    void retrieveAcrobatCheckBoxProperties()
     {
         PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
         assertNotNull(checkbox);
@@ -178,7 +182,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void testAcrobatCheckBoxProperties() throws IOException
+    void testAcrobatCheckBoxProperties() throws IOException
     {
         PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
         assertEquals("Off", checkbox.getValue());
@@ -206,7 +210,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void setValueForAbstractedAcrobatCheckBox() throws IOException
+    void setValueForAbstractedAcrobatCheckBox() throws IOException
     {
         PDField checkbox = acrobatAcroForm.getField("Checkbox");
 
@@ -222,7 +226,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void testAcrobatCheckBoxGroupProperties() throws IOException
+    void testAcrobatCheckBoxGroupProperties() throws IOException
     {
         PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("CheckboxGroup");
         assertEquals("Off", checkbox.getValue());
@@ -264,7 +268,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void setValueForAbstractedCheckBoxGroup() throws IOException
+    void setValueForAbstractedCheckBoxGroup() throws IOException
     {
         PDField checkbox = acrobatAcroForm.getField("CheckboxGroup");
 
@@ -293,7 +297,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void setCheckboxInvalidValue() throws IOException
+    void setCheckboxInvalidValue() throws IOException
     {
         PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("Checkbox");
         // Set a value which doesn't match the radio button list 
@@ -303,7 +307,7 @@ public class PDButtonTest
     }    
 
     @Test
-    public void setCheckboxGroupInvalidValue() throws IOException
+    void setCheckboxGroupInvalidValue() throws IOException
     {
         PDCheckBox checkbox = (PDCheckBox) acrobatAcroForm.getField("CheckboxGroup");
         // Set a value which doesn't match the radio button list 
@@ -313,7 +317,7 @@ public class PDButtonTest
     }    
 
     @Test
-    public void setAbstractedCheckboxInvalidValue() throws IOException
+    void setAbstractedCheckboxInvalidValue() throws IOException
     {
         PDField checkbox = acrobatAcroForm.getField("Checkbox");
         // Set a value which doesn't match the radio button list 
@@ -323,7 +327,7 @@ public class PDButtonTest
     }    
 
     @Test
-    public void setAbstractedCheckboxGroupInvalidValue() throws IOException
+    void setAbstractedCheckboxGroupInvalidValue() throws IOException
     {
         PDField checkbox = acrobatAcroForm.getField("CheckboxGroup");
         // Set a value which doesn't match the radio button list
@@ -333,7 +337,7 @@ public class PDButtonTest
     }    
 
     @Test
-    public void retrieveAcrobatRadioButtonProperties()
+    void retrieveAcrobatRadioButtonProperties()
     {
         PDRadioButton radioButton = (PDRadioButton) acrobatAcroForm.getField("RadioButtonGroup");
         assertNotNull(radioButton);
@@ -343,7 +347,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void testAcrobatRadioButtonProperties() throws IOException
+    void testAcrobatRadioButtonProperties() throws IOException
     {
         PDRadioButton radioButton = (PDRadioButton) acrobatAcroForm.getField("RadioButtonGroup");
 
@@ -367,7 +371,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void setValueForAbstractedAcrobatRadioButton() throws IOException
+    void setValueForAbstractedAcrobatRadioButton() throws IOException
     {
         PDField radioButton = acrobatAcroForm.getField("RadioButtonGroup");
 
@@ -391,7 +395,7 @@ public class PDButtonTest
     }
     
     @Test
-    public void setRadioButtonInvalidValue() throws IOException
+    void setRadioButtonInvalidValue() throws IOException
     {
         PDRadioButton radioButton = (PDRadioButton) acrobatAcroForm.getField("RadioButtonGroup");
         // Set a value which doesn't match the radio button list
@@ -401,7 +405,7 @@ public class PDButtonTest
     }
 
     @Test
-    public void setAbstractedRadioButtonInvalidValue() throws IOException
+    void setAbstractedRadioButtonInvalidValue() throws IOException
     {
         PDField radioButton = acrobatAcroForm.getField("RadioButtonGroup");
         // Set a value which doesn't match the radio button list

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDChoiceTest.java Tue Nov 17 16:40:22 2020
@@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDChoice class.
  *
  */
-public class PDChoiceTest
+class PDChoiceTest
 {
     private PDDocument document;
     private PDAcroForm acroForm;
@@ -52,7 +52,7 @@ public class PDChoiceTest
     }
 
     @Test
-    public void createListBox()
+    void createListBox()
     {
         PDChoice choiceField = new PDListBox(acroForm);
         
@@ -62,7 +62,7 @@ public class PDChoiceTest
     }
 
     @Test
-    public void createComboBox()
+    void createComboBox()
     {
         PDChoice choiceField = new PDComboBox(acroForm);
         
@@ -72,7 +72,7 @@ public class PDChoiceTest
     }
     
     @Test
-    public void getOptionsFromStrings()
+    void getOptionsFromStrings()
     {
         PDChoice choiceField = new PDComboBox(acroForm);
         COSArray choiceFieldOptions = new COSArray();
@@ -88,7 +88,7 @@ public class PDChoiceTest
     }
 
     @Test
-    public void getOptionsFromCOSArray()
+    void getOptionsFromCOSArray()
     {
         PDChoice choiceField = new PDComboBox(acroForm);
         COSArray choiceFieldOptions = new COSArray();
@@ -119,7 +119,7 @@ public class PDChoiceTest
      * Get the entries form a moxed values array. See PDFBOX-4185
      */
     @Test
-    public void getOptionsFromMixed()
+    void getOptionsFromMixed()
     {
         PDChoice choiceField = new PDComboBox(acroForm);
         COSArray choiceFieldOptions = new COSArray();

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDDefaultAppearanceStringTest.java Tue Nov 17 16:40:22 2020
@@ -29,7 +29,7 @@ import org.apache.pdfbox.pdmodel.graphic
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class PDDefaultAppearanceStringTest
+class PDDefaultAppearanceStringTest
 {
     // Used to check resources lookup 
     private PDResources resources;
@@ -45,7 +45,7 @@ public class PDDefaultAppearanceStringTe
     }
     
     @Test
-    public void testParseDAString() throws IOException
+    void testParseDAString() throws IOException
     {
         COSString sampleString = new COSString("/" + fontResourceName.getName() + " 12 Tf 0.019 0.305 0.627 rg");
 
@@ -60,7 +60,7 @@ public class PDDefaultAppearanceStringTe
     }
     
     @Test
-    public void testFontResourceUnavailable() throws IOException
+    void testFontResourceUnavailable() throws IOException
     {
         COSString sampleString = new COSString("/Helvetica 12 Tf 0.019 0.305 0.627 rg");
         assertThrows(IOException.class, () -> {
@@ -69,7 +69,7 @@ public class PDDefaultAppearanceStringTe
     }
     
     @Test
-    public void testWrongNumberOfColorArguments() throws IOException
+    void testWrongNumberOfColorArguments() throws IOException
     {
         COSString sampleString = new COSString("/Helvetica 12 Tf 0.305 0.627 rg");
         assertThrows(IOException.class, () -> {

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDSignatureFieldTest.java Tue Nov 17 16:40:22 2020
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDSignatureField class.
  *
  */
-public class PDSignatureFieldTest
+class PDSignatureFieldTest
 {
     private PDDocument document;
     private PDAcroForm acroForm;
@@ -50,7 +50,7 @@ public class PDSignatureFieldTest
     }
 
     @Test
-    public void createDefaultSignatureField()
+    void createDefaultSignatureField()
     {
         PDSignatureField sigField = new PDSignatureField(acroForm);
         sigField.setPartialName("SignatureField");
@@ -70,7 +70,7 @@ public class PDSignatureFieldTest
     }
     
     @Test
-    public void setValueForAbstractedSignatureField()
+    void setValueForAbstractedSignatureField()
     {
         PDSignatureField sigField = new PDSignatureField(acroForm);
         sigField.setPartialName("SignatureField");
@@ -85,7 +85,7 @@ public class PDSignatureFieldTest
      * @throws IOException 
      */
     @Test
-    public void testGetContents() throws IOException
+    void testGetContents() throws IOException
     {
         // Normally, range0 + range1 = position of "<", and range2 = position after ">"
         PDSignature signature = new PDSignature();

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/form/PDTextFieldTest.java Tue Nov 17 16:40:22 2020
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDSignatureField class.
  *
  */
-public class PDTextFieldTest
+class PDTextFieldTest
 {
     private PDDocument document;
     private PDAcroForm acroForm;
@@ -42,7 +42,7 @@ public class PDTextFieldTest
     }
 
     @Test
-    public void createDefaultTextField()
+    void createDefaultTextField()
     {
         PDField textField = new PDTextField(acroForm);
         
@@ -51,7 +51,7 @@ public class PDTextFieldTest
     }
 
     @Test
-    public void createWidgetForGet()
+    void createWidgetForGet()
     {
         PDTextField textField = new PDTextField(acroForm);
 

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionDirectionTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionDirectionTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionDirectionTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionDirectionTest.java Tue Nov 17 16:40:22 2020
@@ -26,11 +26,11 @@ import org.junit.jupiter.api.Test;
  * @author Andrea Vacondio
  *
  */
-public class PDTransitionDirectionTest
+class PDTransitionDirectionTest
 {
 
     @Test
-    public void getCOSBase()
+    void getCOSBase()
     {
         assertEquals(COSName.NONE, PDTransitionDirection.NONE.getCOSBase());
         assertEquals(0, ((COSInteger) PDTransitionDirection.LEFT_TO_RIGHT.getCOSBase()).intValue());

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/pdmodel/interactive/pagenavigation/PDTransitionTest.java Tue Nov 17 16:40:22 2020
@@ -29,11 +29,11 @@ import org.junit.jupiter.api.Test;
  * @author Andrea Vacondio
  *
  */
-public class PDTransitionTest
+class PDTransitionTest
 {
 
     @Test
-    public void defaultStyle()
+    void defaultStyle()
     {
         PDTransition transition = new PDTransition();
         assertEquals(COSName.TRANS, transition.getCOSObject().getCOSName(COSName.TYPE));
@@ -41,7 +41,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void getStyle()
+    void getStyle()
     {
         PDTransition transition = new PDTransition(PDTransitionStyle.Fade);
         assertEquals(COSName.TRANS, transition.getCOSObject().getCOSName(COSName.TYPE));
@@ -49,7 +49,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void defaultValues()
+    void defaultValues()
     {
         PDTransition transition = new PDTransition(new COSDictionary());
         assertEquals(PDTransitionStyle.R.name(), transition.getStyle());
@@ -62,7 +62,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void dimension()
+    void dimension()
     {
         PDTransition transition = new PDTransition();
         transition.setDimension(PDTransitionDimension.H);
@@ -70,7 +70,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void directionNone()
+    void directionNone()
     {
         PDTransition transition = new PDTransition();
         transition.setDirection(PDTransitionDirection.NONE);
@@ -79,7 +79,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void directionNumber()
+    void directionNumber()
     {
         PDTransition transition = new PDTransition();
         transition.setDirection(PDTransitionDirection.LEFT_TO_RIGHT);
@@ -88,7 +88,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void motion()
+    void motion()
     {
         PDTransition transition = new PDTransition();
         transition.setMotion(PDTransitionMotion.O);
@@ -96,7 +96,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void duration()
+    void duration()
     {
         PDTransition transition = new PDTransition();
         transition.setDuration(4);
@@ -104,7 +104,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void flyScale()
+    void flyScale()
     {
         PDTransition transition = new PDTransition();
         transition.setFlyScale(4);
@@ -112,7 +112,7 @@ public class PDTransitionTest
     }
 
     @Test
-    public void flyArea()
+    void flyArea()
     {
         PDTransition transition = new PDTransition();
         transition.setFlyAreaOpaque(true);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/BidiTest.java Tue Nov 17 16:40:22 2020
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
  * Test for the PDButton class.
  *
  */
-public class BidiTest
+class BidiTest
 {
     /**
      * Logger instance.
@@ -76,14 +76,14 @@ public class BidiTest
     }
 
     @Test
-    public void testSorted() throws IOException
+    void testSorted() throws IOException
     {
         File testFile = new File(IN_DIR, NAME_OF_PDF);
         doTestFile(testFile, outDir, false, true);
     }
 
     @Test
-    public void testNotSorted() throws IOException
+    void testNotSorted() throws IOException
     {
         File testFile = new File(IN_DIR, NAME_OF_PDF);
         doTestFile(testFile, outDir, false, false);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/text/TestTextStripper.java Tue Nov 17 16:40:22 2020
@@ -106,7 +106,7 @@ import org.junit.jupiter.api.Test;
  * @author Robert Dickinson
  * @author Ben Litchfield
  */
-public class TestTextStripper
+class TestTextStripper
 {
 
     /**
@@ -436,7 +436,7 @@ public class TestTextStripper
      * @throws URISyntaxException
      */
     @Test
-    public void testStripByOutlineItems() throws IOException, URISyntaxException
+    void testStripByOutlineItems() throws IOException, URISyntaxException
     {
         PDDocument doc = Loader
                 .loadPDF(new File(TestPDPageTree.class.getResource("with_outline.pdf").toURI()));
@@ -562,7 +562,7 @@ public class TestTextStripper
      * @throws Exception when there is an exception
      */
     @Test
-    public void testExtract() throws Exception
+    void testExtract() throws Exception
     {
         String filename = System.getProperty("org.apache.pdfbox.util.TextStripper.file");
         File inDir = new File("src/test/resources/input");
@@ -593,7 +593,7 @@ public class TestTextStripper
     }
 
     @Test
-    public void testTabula() throws IOException
+    void testTabula() throws IOException
     {
         File pdfFile = new File("src/test/resources/input","eu-001.pdf");
         File outFile = new File("target/test-output","eu-001.pdf-tabula.txt");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/MatrixTest.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/MatrixTest.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/MatrixTest.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/MatrixTest.java Tue Nov 17 16:40:22 2020
@@ -26,11 +26,11 @@ import static org.junit.jupiter.api.Asse
  * @author Neil McErlean
  * @author Tilman Hausherr
  */
-public class MatrixTest
+class MatrixTest
 {
     
     @Test
-    public void testConstructionAndCopy() throws Exception
+    void testConstructionAndCopy() throws Exception
     {
         Matrix m1 = new Matrix();
         assertMatrixIsPristine(m1);
@@ -41,7 +41,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testGetScalingFactor()
+    void testGetScalingFactor()
     {
         // check scaling factor of an initial matrix
         Matrix m1 = new Matrix();
@@ -55,7 +55,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testCreateMatrixUsingInvalidInput()
+    void testCreateMatrixUsingInvalidInput()
     {
         // anything but a COSArray is invalid and leads to an initial matrix
         Matrix createMatrix = Matrix.createMatrix(COSName.A);
@@ -78,7 +78,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testMultiplication()
+    void testMultiplication()
     {
         // These matrices will not change - we use it to drive the various multiplications.
         final Matrix const1 = new Matrix();
@@ -139,7 +139,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testOldMultiplication() throws Exception
+    void testOldMultiplication() throws Exception
     {
         // This matrix will not change - we use it to drive the various multiplications.
         final Matrix testMatrix = new Matrix();
@@ -188,7 +188,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testIllegalValueNaN1()
+    void testIllegalValueNaN1()
     {
         Matrix m = new Matrix();
         m.setValue(0, 0, Float.MAX_VALUE);
@@ -196,7 +196,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testIllegalValueNaN2()
+    void testIllegalValueNaN2()
     {
         Matrix m = new Matrix();
         m.setValue(0, 0, Float.NaN);
@@ -204,7 +204,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testIllegalValuePositiveInfinity()
+    void testIllegalValuePositiveInfinity()
     {
         Matrix m = new Matrix();
         m.setValue(0, 0, Float.POSITIVE_INFINITY);
@@ -212,7 +212,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testIllegalValueNegativeInfinity()
+    void testIllegalValueNegativeInfinity()
     {
         Matrix m = new Matrix();
         m.setValue(0, 0, Float.NEGATIVE_INFINITY);
@@ -223,7 +223,7 @@ public class MatrixTest
      * Test of PDFBOX-2872 bug
      */
     @Test
-    public void testPdfbox2872()
+    void testPdfbox2872()
     {
         Matrix m = new Matrix(2, 4, 5, 8, 2, 0);
         COSArray toCOSArray = m.toCOSArray();
@@ -237,7 +237,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testGetValues()
+    void testGetValues()
     {
         Matrix m = new Matrix(2, 4, 4, 2, 15, 30);
         float[][] values = m.getValues();
@@ -253,7 +253,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testScaling()
+    void testScaling()
     {
         Matrix m = new Matrix(2, 4, 4, 2, 15, 30);
         m.scale(2, 3);
@@ -274,7 +274,7 @@ public class MatrixTest
     }
 
     @Test
-    public void testTranslation()
+    void testTranslation()
     {
         Matrix m = new Matrix(2, 4, 4, 2, 15, 30);
         m.translate(2, 3);

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestDateUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestDateUtil.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestDateUtil.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestDateUtil.java Tue Nov 17 16:40:22 2020
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
  * @author Fred Hansen
  * 
  */
-public class TestDateUtil
+class TestDateUtil
 {
     private static final int MINS = 60*1000, HRS = 60*MINS;
     // expect parse fail
@@ -49,7 +49,7 @@ public class TestDateUtil
      * @throws Exception when there is an exception
      */
     @Test
-    public void testExtract() throws Exception
+    void testExtract() throws Exception
     {
         TimeZone timezone = TimeZone.getDefault();
         TimeZone.setDefault(TimeZone.getTimeZone("UTC"));
@@ -84,7 +84,7 @@ public class TestDateUtil
      * @throws IOException if something went wrong.
      */
     @Test
-    public void testDateConversion() throws IOException 
+    void testDateConversion() throws IOException
     { 
         Calendar c = DateConverter.toCalendar("D:20050526205258+01'00'"); 
         assertEquals(2005, c.get(Calendar.YEAR)); 
@@ -143,7 +143,7 @@ public class TestDateUtil
      * @throws Exception none expected
      */
     @Test
-    public void testDateConverter() throws Exception 
+    void testDateConverter() throws Exception
     {
             int year = Calendar.getInstance().get(Calendar.YEAR);
             checkParse(2010, 4,23, 0, 0, 0, 0, 0, "D:20100423");
@@ -314,7 +314,7 @@ public class TestDateUtil
      * @throws Exception if something went wrong.
      */
     @Test
-    public void testToString() throws Exception 
+    void testToString() throws Exception
     {                                                              // std DST
         TimeZone tzPgh = TimeZone.getTimeZone("America/New_York");   // -5 -4
         TimeZone tzBerlin = TimeZone.getTimeZone("Europe/Berlin");   // +1 +2
@@ -363,7 +363,7 @@ public class TestDateUtil
      * Timezone testcase.
      */
     @Test
-    public void testParseTZ() 
+    void testParseTZ()
     {
         // 1st parameter is what to expect
         checkParseTZ(0*HRS+0*MINS, "+00:00");
@@ -404,7 +404,7 @@ public class TestDateUtil
      * Timezone offset testcase.
      */
     @Test
-    public void testFormatTZoffset()
+    void testFormatTZoffset()
     {
         // 2nd parameter is what to expect
         checkFormatOffset(-12.1, "-12:06");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestHexUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestHexUtil.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestHexUtil.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestHexUtil.java Tue Nov 17 16:40:22 2020
@@ -27,14 +27,14 @@ import static org.junit.jupiter.api.Asse
  *
  * @author Michael Doswald
  */
-public class TestHexUtil
+class TestHexUtil
 {
     
     /**
      * Test conversion from short to char[]
      */
     @Test
-    public void testGetCharsFromShortWithoutPassingInABuffer()
+    void testGetCharsFromShortWithoutPassingInABuffer()
     {
         assertArrayEquals(new char[]{'0','0','0','0'}, Hex.getChars((short)0x0000));
         assertArrayEquals(new char[]{'0','0','0','F'}, Hex.getChars((short)0x000F));
@@ -48,7 +48,7 @@ public class TestHexUtil
      *
      */
     @Test
-    public void testGetCharsUTF16BE()
+    void testGetCharsUTF16BE()
     {
         assertArrayEquals(new char[]{'0','0','6','1','0','0','6','2'}, Hex.getCharsUTF16BE("ab"));
         assertArrayEquals(new char[]{'5','E','2','E','5','2','A','9'}, Hex.getCharsUTF16BE("帮助"));
@@ -58,7 +58,7 @@ public class TestHexUtil
      * Test getBytes() and getString() and decodeHex()
      */
     @Test
-    public void testMisc()
+    void testMisc()
     {
         byte[] byteSrcArray = new byte[256];
         for (int i = 0; i < 256; ++i)

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestNumberFormatUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestNumberFormatUtil.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestNumberFormatUtil.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestNumberFormatUtil.java Tue Nov 17 16:40:22 2020
@@ -33,13 +33,13 @@ import org.junit.jupiter.api.Test;
  *
  * @author Michael Doswald
  */
-public class TestNumberFormatUtil
+class TestNumberFormatUtil
 {
 
     private final byte[] buffer = new byte[64];
 
     @Test
-    public void testFormatOfIntegerValues()
+    void testFormatOfIntegerValues()
     {
         assertEquals(2, NumberFormatUtil.formatFloatFast(51, 5, buffer));
         assertArrayEquals(new byte[]{'5', '1'}, Arrays.copyOfRange(buffer, 0, 2));
@@ -68,7 +68,7 @@ public class TestNumberFormatUtil
     }
 
     @Test
-    public void testFormatOfRealValues()
+    void testFormatOfRealValues()
     {
         assertEquals(3, NumberFormatUtil.formatFloatFast(0.7f, 5, buffer));
         assertArrayEquals(new byte[]{'0', '.', '7'}, Arrays.copyOfRange(buffer, 0, 3));
@@ -85,7 +85,7 @@ public class TestNumberFormatUtil
     }
 
     @Test
-    public void testFormatOfRealValuesReturnsMinusOneIfItCannotBeFormatted()
+    void testFormatOfRealValuesReturnsMinusOneIfItCannotBeFormatted()
     {
         assertEquals(-1, NumberFormatUtil.formatFloatFast(Float.NaN, 5, buffer),
                 "NaN should not be formattable");
@@ -100,7 +100,7 @@ public class TestNumberFormatUtil
     }
 
     @Test
-    public void testRoundingUp()
+    void testRoundingUp()
     {
         assertEquals(1, NumberFormatUtil.formatFloatFast(0.999999f, 5, buffer));
         assertArrayEquals(new byte[]{'1'}, Arrays.copyOfRange(buffer, 0, 1));
@@ -113,7 +113,7 @@ public class TestNumberFormatUtil
     }
     
     @Test
-    public void testRoundingDown()
+    void testRoundingDown()
     {
         assertEquals(4, NumberFormatUtil.formatFloatFast(0.994f, 2, buffer));
         assertArrayEquals(new byte[]{'0','.','9','9'}, Arrays.copyOfRange(buffer, 0, 4));
@@ -130,7 +130,7 @@ public class TestNumberFormatUtil
      * </ul>
      */
     @Test
-    public void testFormattingInRange()
+    void testFormattingInRange()
     {
         //Define a range to test
         BigDecimal minVal = new BigDecimal("-10");

Modified: pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestQuickSort.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestQuickSort.java?rev=1883546&r1=1883545&r2=1883546&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestQuickSort.java (original)
+++ pdfbox/trunk/pdfbox/src/test/java/org/apache/pdfbox/util/TestQuickSort.java Tue Nov 17 16:40:22 2020
@@ -28,7 +28,7 @@ import org.junit.jupiter.api.Test;
  *
  * @author Uwe Pachler
  */
-public class TestQuickSort
+class TestQuickSort
 {
 
     <T extends Comparable<T>> void doTest(T[] input, T[] expected)
@@ -43,7 +43,7 @@ public class TestQuickSort
      * Test for different cases.
      */
     @Test
-    public void testSort()
+    void testSort()
     {
 
         {