You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/22 02:53:00 UTC
[GitHub] [pulsar] momo-jun opened a new pull request #14406: [Doc] [Do-not-Merge] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
momo-jun opened a new pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406
### Modifications
To align doc with code https://github.com/apache/pulsar/pull/8289, the following changes have been made:
1. Add `maxSubscriptionsPerTopic` to both broker and standalone configurations
2. Copy/paste `maxProducersPerTopic`, `maxConsumersPerTopic` and `maxConsumersPerSubscription` from standalone configurations to broker configurations because these three parameters are in the broker.conf file.
> Please kindly note that the same changes will be applied to more historical versions as long as it gets approval.
### Documentation
- [ ] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14406: [Doc] [Do-not-Merge] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406#discussion_r811561081
##########
File path: site2/docs/reference-configuration.md
##########
@@ -208,6 +208,10 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+| maxSubscriptionsPerTopic | Maximum number of subscriptions allowed to subscribe to a topic. Once this limit reaches, the broker rejects new subscriptions until the number of subscriptions decreases. When the value is set to 0, maxSubscriptionsPerTopic-limit check is disabled. | 0 |
Review comment:
```suggestion
| maxSubscriptionsPerTopic | Maximum number of subscriptions allowed to subscribe to a topic. Once this limit reaches, the broker rejects new subscriptions until the number of subscriptions decreases. When the value is set to 0, `maxSubscriptionsPerTopic-limit` check is disabled. | 0 |
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -208,6 +208,10 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+| maxSubscriptionsPerTopic | Maximum number of subscriptions allowed to subscribe to a topic. Once this limit reaches, the broker rejects new subscriptions until the number of subscriptions decreases. When the value is set to 0, maxSubscriptionsPerTopic-limit check is disabled. | 0 |
+| maxProducersPerTopic | Maximum number of producers allowed to connect to a topic. Once this limit reaches, the broker rejects new producers until the number of connected producers decreases. When the value is set to 0, maxProducersPerTopic-limit check is disabled. | 0 |
Review comment:
```suggestion
| maxProducersPerTopic | Maximum number of producers allowed to connect to a topic. Once this limit reaches, the broker rejects new producers until the number of connected producers decreases. When the value is set to 0, `maxProducersPerTopic-limit` check is disabled. | 0 |
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -208,6 +208,10 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+| maxSubscriptionsPerTopic | Maximum number of subscriptions allowed to subscribe to a topic. Once this limit reaches, the broker rejects new subscriptions until the number of subscriptions decreases. When the value is set to 0, maxSubscriptionsPerTopic-limit check is disabled. | 0 |
+| maxProducersPerTopic | Maximum number of producers allowed to connect to a topic. Once this limit reaches, the broker rejects new producers until the number of connected producers decreases. When the value is set to 0, maxProducersPerTopic-limit check is disabled. | 0 |
+| maxConsumersPerTopic | Maximum number of consumers allowed to connect to a topic. Once this limit reaches, the broker rejects new consumers until the number of connected consumers decreases. When the value is set to 0, maxConsumersPerTopic-limit check is disabled. | 0 |
Review comment:
```suggestion
| maxConsumersPerTopic | Maximum number of consumers allowed to connect to a topic. Once this limit reaches, the broker rejects new consumers until the number of connected consumers decreases. When the value is set to 0, `maxConsumersPerTopic-limit check` is disabled. | 0 |
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -208,6 +208,10 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+| maxSubscriptionsPerTopic | Maximum number of subscriptions allowed to subscribe to a topic. Once this limit reaches, the broker rejects new subscriptions until the number of subscriptions decreases. When the value is set to 0, maxSubscriptionsPerTopic-limit check is disabled. | 0 |
+| maxProducersPerTopic | Maximum number of producers allowed to connect to a topic. Once this limit reaches, the broker rejects new producers until the number of connected producers decreases. When the value is set to 0, maxProducersPerTopic-limit check is disabled. | 0 |
+| maxConsumersPerTopic | Maximum number of consumers allowed to connect to a topic. Once this limit reaches, the broker rejects new consumers until the number of connected consumers decreases. When the value is set to 0, maxConsumersPerTopic-limit check is disabled. | 0 |
+| maxConsumersPerSubscription | Maximum number of consumers allowed to connect to a subscription. Once this limit reaches, the broker rejects new consumers until the number of connected consumers decreases. When the value is set to 0, maxConsumersPerSubscription-limit check is disabled. | 0 |
Review comment:
```suggestion
| maxConsumersPerSubscription | Maximum number of consumers allowed to connect to a subscription. Once this limit reaches, the broker rejects new consumers until the number of connected consumers decreases. When the value is set to 0, `maxConsumersPerSubscription-limit` check is disabled. | 0 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #14406: [Doc] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406#issuecomment-1048565970
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14406: [Doc] [Do-not-Merge] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406#issuecomment-1047376201
@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14406: [Doc] [Do-not-Merge] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406#issuecomment-1047376248
@momo-jun:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #14406: [Doc] [Do-not-Merge] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406#issuecomment-1047376314
Hi @hangc0276 @Anonymitaet can you please review this doc PR? Thanks.
Please kindly note that the same changes will be applied to more historical versions as long as it gets approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #14406: [Doc] Add `maxSubscriptionsPerTopic` to broker and standalone configurations
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #14406:
URL: https://github.com/apache/pulsar/pull/14406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org