[GitHub] eolivelli commented on a change in pull request #217: Set properties readonly where it doesn't make sense to change values

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #217: Set properties readonly where it doesn't make sense to change values
URL: https://github.com/apache/maven-surefire/pull/217#discussion_r250492538
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##########
 @@ -242,11 +242,12 @@
     private String[] additionalClasspathElements;
 
     /**
-     * The test source directory containing test class sources.
+     * The test source directory containing test class sources. Only used by the TestNG provider to process JavaDoc
+     * tags.
      *
      * @since 2.2
      */
-    @Parameter( defaultValue = "${project.build.testSourceDirectory}", required = true )
+    @Parameter( defaultValue = "${project.build.testSourceDirectory}", readonly = true )
     private File testSourceDirectory;
 
 Review comment:
   Not sure about this

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services