You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/10 15:10:05 UTC
[GitHub] [hive] miklosgergely opened a new pull request #1845: HIVE-24610 Remove superfluous throws IOException from Context
miklosgergely opened a new pull request #1845:
URL: https://github.com/apache/hive/pull/1845
### What changes were proposed in this pull request?
Remove superfluous throws IOException from Context constructor, which may never be thrown.
### Why are the changes needed?
To keep the code clean by not having unused parts in it.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
All the tests are still running fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1845: HIVE-24610 Remove superfluous throws IOException from Context
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1845:
URL: https://github.com/apache/hive/pull/1845#discussion_r555030681
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java
##########
@@ -196,7 +196,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testBuildDag() throws IllegalArgumentException, IOException, Exception {
+ public void testBuildDag() throws IllegalArgumentException, Exception {
Review comment:
Listing `IllegalArgumentException` is not necessary if `Exception` can be thrown.
Or this can be tackled in a follow-up
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #1845: HIVE-24610 Remove superfluous throws IOException from Context
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #1845:
URL: https://github.com/apache/hive/pull/1845#discussion_r555057154
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java
##########
@@ -196,7 +196,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testBuildDag() throws IllegalArgumentException, IOException, Exception {
+ public void testBuildDag() throws IllegalArgumentException, Exception {
Review comment:
Nice catch, thanks, fixed.
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java
##########
@@ -217,7 +217,7 @@ public void testBuildDag() throws IllegalArgumentException, IOException, Excepti
}
@Test
- public void testEmptyWork() throws IllegalArgumentException, IOException, Exception {
+ public void testEmptyWork() throws IllegalArgumentException, Exception {
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely merged pull request #1845: HIVE-24610 Remove superfluous throws IOException from Context
Posted by GitBox <gi...@apache.org>.
miklosgergely merged pull request #1845:
URL: https://github.com/apache/hive/pull/1845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a change in pull request #1845: HIVE-24610 Remove superfluous throws IOException from Context
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on a change in pull request #1845:
URL: https://github.com/apache/hive/pull/1845#discussion_r555030681
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java
##########
@@ -196,7 +196,7 @@ public void tearDown() throws Exception {
}
@Test
- public void testBuildDag() throws IllegalArgumentException, IOException, Exception {
+ public void testBuildDag() throws IllegalArgumentException, Exception {
Review comment:
Listing `IllegalArgumentException` is not necessary if `Exception` can be thrown.
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java
##########
@@ -217,7 +217,7 @@ public void testBuildDag() throws IllegalArgumentException, IOException, Excepti
}
@Test
- public void testEmptyWork() throws IllegalArgumentException, IOException, Exception {
+ public void testEmptyWork() throws IllegalArgumentException, Exception {
Review comment:
Listing `IllegalArgumentException` is not necessary if `Exception` can be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org