[GitHub] [inlong] healchow commented on a diff in pull request #8530: [INLONG-8529][Manager] Update stream source to heartbeat timeout when evit cluster node

["healchow (via GitHub)" <gi...@apache.org>]

healchow commented on code in PR #8530:
URL: https://github.com/apache/inlong/pull/8530#discussion_r1263345201


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java:
##########
@@ -256,6 +258,21 @@ private void evictClusterNode(HeartbeatMsg heartbeat) {
             }
             clusterNode.setStatus(NodeStatus.HEARTBEAT_TIMEOUT.getStatus());
             clusterNodeMapper.updateById(clusterNode);
+            if (Objects.equals(clusterNode.getType(), ClusterType.AGENT)) {
+                List<Integer> statusList =

Review Comment:
   Maybe this `statusList` can extract to be a global constant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org