You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by fredtitao <gi...@git.apache.org> on 2015/02/05 13:12:18 UTC
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
GitHub user fredtitao opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36
Add missing module references for Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wingz-inc/cordova-plugin-geolocation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 09e84585751dd9134a6620b850bc52e37595465f
Author: Fred Gomez <fr...@gmail.com>
Date: 2015-02-05T12:09:53Z
Add missing module references for Android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103808749
Android geolocation plugin code doesn't exist anymore, it just uses the HTML 5 geolocation API, so nothing has to be copied to the platform folder to make the plugin work, just the androidManifest permissions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Posted by digiclick74 <gi...@git.apache.org>.
Github user digiclick74 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103426643
Sorry but I don't have the permissions to merge the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Posted by timuric <gi...@git.apache.org>.
Github user timuric commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103402749
Can you please merge this request, otherwise plugin does not install on android
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-104742963
Just as @jcesarmobile said, there are no modules needed, therefore this should be closed. Because this is a copy of the repository, and not the repository itself, I can't close this one from here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org