[jira] [Commented] (PHOENIX-6611) Fix IndexTool -snap option and set VERIFIED in PhoenixIndexImportDirectReducer

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461009#comment-17461009 ] 

ASF GitHub Bot commented on PHOENIX-6611:
-----------------------------------------

gjacoby126 commented on a change in pull request #1365:
URL: https://github.com/apache/phoenix/pull/1365#discussion_r770861899



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -493,6 +493,10 @@ public Job getJob() throws Exception {
                 }
                 if (useSnapshot || (!isLocalIndexBuild && pDataTable.isTransactional())) {
                     PhoenixConfigurationUtil.setCurrentScnValue(configuration, maxTimeRange);
+                    if (indexVerifyType != IndexVerifyType.NONE) {
+                        LOGGER.warn("Verification is not supported for client index rebuilds,"

Review comment:
       The error message seems wrong -- verification is supported for some client-initiated index rebuilds, just not ones using a mapper other than the server build one. If you mean that the direct mapper creates the mutations and writes them as a client, that's probably not clear to the end user. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix IndexTool -snap option and set VERIFIED in PhoenixIndexImportDirectReducer  
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6611
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.2.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> While fixing a trivial problem I introduced in PHOENIX-6601, I have expanded the ITs, and found a several bugs with IndexTool.
> * Indexes generated by PhoenixIndexImportDirectReducer do not handle rows modified after the index table was created. (related to PHOENIX-5375, PHOENIX-5376)
> * Global secondary index cells generated by PhoenixIndexImportDirectReducer do not have the VERIFIED flag set (similar to PHOENIX-6386)
> * IndexTool cannot be run on the same table multiple  withh -snapshot, unless the snapshot is manually deleted. 
> * Global secondary index cells on transactional tables do not have the VERIFIED flag set.
> * Invalid snapshot name is generated for snapshot with namespace mapping enabled. (PHOENIX-6601 regression)
> Some more test issues:
> * IndexToolIT is not run with snapshots, or with namespace mapping enabled.
> * The obsolete directApi option is all over the test code.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)