You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/12/04 20:39:09 UTC
[kudu-CR] [test] Break up test output per test case.
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12031
Change subject: [test] Break up test output per test case.
......................................................................
[test] Break up test output per test case.
Currently when generating the JUnit XML for each
test suite Gradle appends all of the test output to
stderr and stdout at the suit level. This
change ensures Gradle will break up the output
by each test case instead.
Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
---
M java/gradle/tests.gradle
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/12031/1
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [test] Break up test output per test case.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@32
PS1, Line 32: // Break up the stdout and stderr logging by test case.
Don't you want to do it in the fancy closure style? Like
reports {
junitXml {
outputPerTestCase(true)
}
}
Or some such.
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 21:32:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@10
PS1, Line 10: test suite Gradle appends all of the test output to
nit: ,
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@11
PS1, Line 11: suit
suite
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@33
PS1, Line 33: getReports().getJunitXml().setOutputPerTestCase(true)
Just to double-check: this will make each test case have its logs in a child node of the test case node in the xml, and in particular the increase to the size of the logs is minimal- just the extra characters for the extra XML nodes?
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 21:23:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:32:19 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Break up test output per test case.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@32
PS1, Line 32: // Break up the stdout and stderr logging by test case.
> Don't you want to do it in the fancy closure style? Like
I am indifferent. I go the closure approach if there is more than one item at each level, but often opt for the simple one-liner when possible. I think I could do reports.junitXml.setOutputPerTestCase(true) if you prefer, I am not set on a way about that either.
http://gerrit.cloudera.org:8080/#/c/12031/1/java/gradle/tests.gradle@33
PS1, Line 33: reports.junitXml.outputPerTestCase = true
> Just to double-check: this will make each test case have its logs in a chil
yeah, exactly. Instead of all in one node in the footer it will be broken up below each testcase node.
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 16:33:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 18:06:33 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Break up test output per test case.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@10
PS1, Line 10: test suite Gradle appends all of the test output to
> nit: ,
Done
http://gerrit.cloudera.org:8080/#/c/12031/1//COMMIT_MSG@11
PS1, Line 11: suit
> suite
Done
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 16:34:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Break up test output per test case.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12031
to look at the new patch set (#2).
Change subject: [test] Break up test output per test case.
......................................................................
[test] Break up test output per test case.
Currently, when generating the JUnit XML for each
test suite Gradle appends all of the test output to
stderr and stdout at the suite level. This
change ensures Gradle will break up the output
by each test case instead.
Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
---
M java/gradle/tests.gradle
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/12031/2
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [test] Break up test output per test case.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12031 )
Change subject: [test] Break up test output per test case.
......................................................................
[test] Break up test output per test case.
Currently, when generating the JUnit XML for each
test suite Gradle appends all of the test output to
stderr and stdout at the suite level. This
change ensures Gradle will break up the output
by each test case instead.
Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Reviewed-on: http://gerrit.cloudera.org:8080/12031
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/gradle/tests.gradle
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If7564e48cddc7bf7ea7595d925f605802259dced
Gerrit-Change-Number: 12031
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>