[GitHub] [tvm] junrushao commented on a diff in pull request #14316: [TensorIR] New schedule primitive `set_dtype`

["junrushao (via GitHub)" <gi...@apache.org>]

junrushao commented on code in PR #14316:
URL: https://github.com/apache/tvm/pull/14316#discussion_r1141615769


##########
include/tvm/tir/schedule/schedule.h:
##########
@@ -584,13 +584,21 @@ class ScheduleNode : public runtime::Object {
   virtual void StorageAlign(const BlockRV& block_rv, int buffer_index, int axis, int factor,
                             int offset) = 0;
   /*!
-   * \brief Set the storage scope of a buffer, where the buffer is specified by the a block and a
+   * \brief Set the storage scope of a buffer, where the buffer is specified by a block and a
    * write-index
    * \param block_rv The producer block of the buffer
    * \param buffer_index The index of the buffer in block's write region
    * \param storage_scope The storage scope to be set
    */
   virtual void SetScope(const BlockRV& block_rv, int buffer_index, const String& storage_scope) = 0;
+  /*!
+   * \brief Set the data type of a buffer, where the buffer is specified by a block and a
+   * write-index
+   * \param block_rv The producer block of the buffer
+   * \param buffer_index the index of the buffer in block's write region
+   * \param dtype The data type to be set
+   */
+  virtual void SetDType(const BlockRV& block_rv, int buffer_index, const String& dtype) = 0;

Review Comment:
   looks like we missed a couple of places lol



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org