You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/05 22:32:20 UTC
[jira] [Commented] (TINKERPOP-1458) Gremlin Server doesn't return
confirmation upon Traversal OpProcessor "close" op
[ https://issues.apache.org/jira/browse/TINKERPOP-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550153#comment-15550153 ]
ASF GitHub Bot commented on TINKERPOP-1458:
-------------------------------------------
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/451
Tinkerpop 1458 Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close" op
https://issues.apache.org/jira/browse/TINKERPOP-1458
This PR updates the Gremlin Server protocol to send a no content confirmation when a client submits a `close` Op with the `traversal` OpProcessor.
It also adds close methods to the Java driver `DriverRemoteTraversalSideEffects` class and the gremlin-python `RemoteTraversalSideEffects` class. Furthermore, `RemoteTraversalSideEffects` now caches side effects locally in order to maintain consistent behavior between the two implementations.
This functionality is tested using integration tests in both the gremlin-server and gremlin-python module, as well as in the gremlin-driver unit tests with mocked responses.
Thanks to @spmallette for helping me through the Java stuff.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1458
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #451
----
commit 8ab7e50824ee72393c23d416ee2ea8348145b4bf
Author: davebshow <da...@apache.org>
Date: 2016-09-22T18:51:21Z
TraversalOpProcessor returns a success message upon receiveing a close command
commit 733bd7e29d7da1a4b972d208cb3ef6f32861e67e
Author: davebshow <da...@apache.org>
Date: 2016-09-26T17:25:17Z
added close method to gremlin python sideeffects
commit ef553d5f72fe10bfc10342981452a93d75deb203
Author: davebshow <da...@gmail.com>
Date: 2016-09-29T15:55:09Z
added close method to DriverRemoteTraversalSideEffects, implement AutoCloseable on TraversalSideEffects, add test for close method
commit e574bbf867e1ec6c7bbba59f1395648e5cd0fc5a
Author: davebshow <da...@gmail.com>
Date: 2016-09-29T16:04:03Z
got rid of wildcard set by intellij
commit 10779228ba5ed07ab43e84bef458e17fdfb9deb8
Author: davebshow <da...@gmail.com>
Date: 2016-09-29T17:04:57Z
fixed logic in DriverRemoteSideEffects, don't clear local side effect cache
commit d60def3d45d2618c681d6b2f88f1a7017b09f407
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-09-30T13:23:29Z
Add some tests for DriverRemoteTraversalSideEffects.
commit 790aa060ce828b8d76f90b06f59e770431e7b732
Author: davebshow <da...@gmail.com>
Date: 2016-10-05T19:01:59Z
added integration tests for DriverRemoteTraversalSideEffects methods
commit fd2d6eb86f9d45a709d0684a23d57c83c18f5826
Author: davebshow <da...@gmail.com>
Date: 2016-10-05T21:59:15Z
fixed side effect methods and updated tests
commit f3baae8ba2415191e700c3842f983001096168e5
Author: davebshow <da...@gmail.com>
Date: 2016-10-05T22:00:27Z
updated driver to cache side effects locally
commit ff41aafd2563d59e3fc95bb310708c5ebd61a4ce
Author: davebshow <da...@gmail.com>
Date: 2016-10-05T22:06:02Z
removed extra lines
commit 89a5f37724833d45618fdc4f7eb6fa22ddaaf783
Author: davebshow <da...@gmail.com>
Date: 2016-10-05T22:10:15Z
updated changelog
----
> Gremlin Server doesn't return confirmation upon Traversal OpProcessor "close" op
> --------------------------------------------------------------------------------
>
> Key: TINKERPOP-1458
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1458
> Project: TinkerPop
> Issue Type: Bug
> Components: server
> Affects Versions: 3.2.2
> Reporter: David M. Brown
> Assignee: David M. Brown
> Fix For: 3.2.3
>
>
> Gremlin Server should return some sort of success message to driver upon invalidating the side effect cache for a traversal.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)