You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/05/30 16:11:58 UTC

Review Request 22083: Bootstrap API call says bootstrap is running even though all agents have installed and registered

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22083/
-----------------------------------------------------------

Review request for Ambari and Andrew Onischuk.


Bugs: AMBARI-5957
    https://issues.apache.org/jira/browse/AMBARI-5957


Repository: ambari


Description
-------

I suspected time.sleep(1) instruction. If restart takes too long time, situation, when ambari-agent.log has not been created yet is possible. So, tail command returned not 0 retcode and exit from procedure. But in logs I cant see any non-zero retcodes. Thus, too short logs could be explaned by this issue.


Diffs
-----

  ambari-server/src/main/python/setupAgent.py 28651e7 
  ambari-server/src/test/python/TestSetupAgent.py 508ae3f 

Diff: https://reviews.apache.org/r/22083/diff/


Testing
-------

----------------------------------------------------------------------
Ran 207 tests in 1.703s

OK
----------------------------------------------------------------------
Total run:560
Total errors:0
Total failures:0
OK


Thanks,

Dmitro Lisnichenko


Re: Review Request 22083: Bootstrap API call says bootstrap is running even though all agents have installed and registered

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22083/#review44368
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On May 30, 2014, 2:11 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22083/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 2:11 p.m.)
> 
> 
> Review request for Ambari and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-5957
>     https://issues.apache.org/jira/browse/AMBARI-5957
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I suspected time.sleep(1) instruction. If restart takes too long time, situation, when ambari-agent.log has not been created yet is possible. So, tail command returned not 0 retcode and exit from procedure. But in logs I cant see any non-zero retcodes. Thus, too short logs could be explaned by this issue.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/setupAgent.py 28651e7 
>   ambari-server/src/test/python/TestSetupAgent.py 508ae3f 
> 
> Diff: https://reviews.apache.org/r/22083/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 207 tests in 1.703s
> 
> OK
> ----------------------------------------------------------------------
> Total run:560
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>