[GitHub] [lucene] jpountz commented on a change in pull request #94: LUCENE-9907: Remove unused methods in PackedInts

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #94:
URL: https://github.com/apache/lucene/pull/94#discussion_r615777238



##########
File path: lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java
##########
@@ -506,13 +504,13 @@ public void clear() {
     }
 
     /**
-     * Save this mutable into <code>out</code>. Instantiating a reader from the generated data will
-     * return a reader with the same number of bits per value.
+     * Save this mutable into <code>out</code>. This method does not write any metadata to the
+     * stream, meaning that it is your responsibility to store it somewhere else in order to be able
+     * to recover data from the stream later on.
      */
     public void save(DataOutput out) throws IOException {

Review comment:
       Should we remove this method too? It doesn't seem to be used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org