You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/25 02:18:43 UTC

[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #312: [ISSUE #308]add default topic check to filter warning logs.

ifplusor commented on a change in pull request #312:
URL: https://github.com/apache/rocketmq-client-cpp/pull/312#discussion_r429706535



##########
File path: src/MQClientAPIImpl.cpp
##########
@@ -325,7 +325,9 @@ TopicRouteData* MQClientAPIImpl::getTopicRouteInfoFromNameServer(const string& t
           }
         }
         case TOPIC_NOT_EXIST: {
-          LOG_WARN("Get topic[%s] route failed [TOPIC_NOT_EXIST].", topic.c_str());
+          if (DEFAULT_TOPIC.compare(topic) != 0) {

Review comment:
       Why not use ```topic != DEFAULT_TOPIC``` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org