You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2013/04/09 09:27:14 UTC
Review Request: Improve website for upcoming release
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/
-----------------------------------------------------------
Review request for giraph.
Description
-------
The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
* Modified ConfigurationUtils.java to support a non-munged profile
* Updated incubator references
* Added hudson location
* Site now is a multi-module site instead of giraph-core only
* Changed site layout to be more modern using the fluido skin
* Added instructions on building the site
* Added initial Hello, Page Rank example
* Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
This addresses bug GIRAPH-612.
https://issues.apache.org/jira/browse/GIRAPH-612
Diffs
-----
giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
src/site/resources/css/site.css PRE-CREATION
src/site/resources/images/ApacheGiraph.svg PRE-CREATION
src/site/site.xml PRE-CREATION
src/site/xdoc/build_site.xml PRE-CREATION
src/site/xdoc/hello_pagerank.xml PRE-CREATION
src/site/xdoc/index.xml PRE-CREATION
src/site/xdoc/javadoc_modules.xml PRE-CREATION
Diff: https://reviews.apache.org/r/10365/diff/
Testing
-------
Built the site.
Thanks,
Avery Ching
Re: Review Request: Improve website for upcoming release
Posted by Alessandro Presta <al...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/#review18900
-----------------------------------------------------------
Ship it!
Ship It!
- Alessandro Presta
On April 9, 2013, 10:42 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10365/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 10:42 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
>
> * Google +1 / Facebook like support
> * Google site search support
> * Modified ConfigurationUtils.java to support a non-munged profile
> * Updated incubator references
> * Added hudson location
> * Site now is a multi-module site instead of giraph-core only
> * Changed site layout to be more modern using the fluido skin
> * Added instructions on building the site
> * Added initial Hello, Page Rank example
> * Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
>
>
> This addresses bug GIRAPH-612.
> https://issues.apache.org/jira/browse/GIRAPH-612
>
>
> Diffs
> -----
>
> giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
> giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
> giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
> giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
> giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
> giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
> giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
> giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
> giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
> giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
> pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
> src/site/resources/css/site.css PRE-CREATION
> src/site/resources/images/ApacheGiraph.svg PRE-CREATION
> src/site/site.xml PRE-CREATION
> src/site/xdoc/build_site.xml PRE-CREATION
> src/site/xdoc/generating_patches.xml PRE-CREATION
> src/site/xdoc/index.xml PRE-CREATION
> src/site/xdoc/javadoc_modules.xml PRE-CREATION
> src/site/xdoc/pagerank.xml PRE-CREATION
> src/site/xdoc/presentations.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10365/diff/
>
>
> Testing
> -------
>
> Built the site.
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: Improve website for upcoming release
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/
-----------------------------------------------------------
(Updated April 9, 2013, 10:42 p.m.)
Review request for giraph.
Changes
-------
Changed the license to point to the 2.0 license.
Removed a few out-of-date links in the user docs
Description
-------
The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
* Google +1 / Facebook like support
* Google site search support
* Modified ConfigurationUtils.java to support a non-munged profile
* Updated incubator references
* Added hudson location
* Site now is a multi-module site instead of giraph-core only
* Changed site layout to be more modern using the fluido skin
* Added instructions on building the site
* Added initial Hello, Page Rank example
* Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
This addresses bug GIRAPH-612.
https://issues.apache.org/jira/browse/GIRAPH-612
Diffs (updated)
-----
giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
src/site/resources/css/site.css PRE-CREATION
src/site/resources/images/ApacheGiraph.svg PRE-CREATION
src/site/site.xml PRE-CREATION
src/site/xdoc/build_site.xml PRE-CREATION
src/site/xdoc/generating_patches.xml PRE-CREATION
src/site/xdoc/index.xml PRE-CREATION
src/site/xdoc/javadoc_modules.xml PRE-CREATION
src/site/xdoc/pagerank.xml PRE-CREATION
src/site/xdoc/presentations.xml PRE-CREATION
Diff: https://reviews.apache.org/r/10365/diff/
Testing
-------
Built the site.
Thanks,
Avery Ching
Re: Review Request: Improve website for upcoming release
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/
-----------------------------------------------------------
(Updated April 9, 2013, 10:25 p.m.)
Review request for giraph.
Changes
-------
Addressed Alessandro's comments.
Description
-------
The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
* Google +1 / Facebook like support
* Google site search support
* Modified ConfigurationUtils.java to support a non-munged profile
* Updated incubator references
* Added hudson location
* Site now is a multi-module site instead of giraph-core only
* Changed site layout to be more modern using the fluido skin
* Added instructions on building the site
* Added initial Hello, Page Rank example
* Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
This addresses bug GIRAPH-612.
https://issues.apache.org/jira/browse/GIRAPH-612
Diffs (updated)
-----
giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
src/site/resources/css/site.css PRE-CREATION
src/site/resources/images/ApacheGiraph.svg PRE-CREATION
src/site/site.xml PRE-CREATION
src/site/xdoc/build_site.xml PRE-CREATION
src/site/xdoc/generating_patches.xml PRE-CREATION
src/site/xdoc/index.xml PRE-CREATION
src/site/xdoc/javadoc_modules.xml PRE-CREATION
src/site/xdoc/pagerank.xml PRE-CREATION
src/site/xdoc/presentations.xml PRE-CREATION
Diff: https://reviews.apache.org/r/10365/diff/
Testing
-------
Built the site.
Thanks,
Avery Ching
Re: Review Request: Improve website for upcoming release
Posted by Avery Ching <av...@gmail.com>.
> On April 9, 2013, 5:39 p.m., Alessandro Presta wrote:
> > Looks much nicer!
> > Some random comments:
> > - I would try to reduce the amount of text on the landing page as much as possible: a few key sentences on the project (reference BSP, Pregel, Hadoop), how to build, and maybe a code snippet to show the vertex API. Everything else could probably be moved down or to other pages.
> > - The logo wastes quite a lot of space the way it's positioned (look at all the white space to its right). It would be better if it was side by side with the title or other text.
> > - There are some links to content that's probably outdated (e.g, the shortest paths example, the quick start guide). The menus could probably be better organized: we could separate user-oriented info (summary, license, mailing lists etc) from developer info (how to build the site, continuous integration, etc). The Modules section seems useless right now. License should probably link to the specific version. Do we even use all those Reports?
> > - The PageRank example currently has no code snippets. Also, in my opinion it's sufficient to call it PageRank (the Hello sounds a bit weird to me...).
I reduced the text a bit on the landing page (carved out two separate pages - how to contribute and presentations).
Unfortunately, the design limits what we can do with the logo easily.
Changed Hello Page rank to just page rank. I think the full example will require a bit more effort. Let's put what we have in now so that we can get everyone working on some documentation.
Here's the revised site:
http://people.apache.org/~aching/staging/
- Avery
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/#review18861
-----------------------------------------------------------
On April 9, 2013, 10:25 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10365/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 10:25 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
>
> * Google +1 / Facebook like support
> * Google site search support
> * Modified ConfigurationUtils.java to support a non-munged profile
> * Updated incubator references
> * Added hudson location
> * Site now is a multi-module site instead of giraph-core only
> * Changed site layout to be more modern using the fluido skin
> * Added instructions on building the site
> * Added initial Hello, Page Rank example
> * Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
>
>
> This addresses bug GIRAPH-612.
> https://issues.apache.org/jira/browse/GIRAPH-612
>
>
> Diffs
> -----
>
> giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
> giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
> giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
> giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
> giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
> giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
> giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
> giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
> giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
> giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
> pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
> src/site/resources/css/site.css PRE-CREATION
> src/site/resources/images/ApacheGiraph.svg PRE-CREATION
> src/site/site.xml PRE-CREATION
> src/site/xdoc/build_site.xml PRE-CREATION
> src/site/xdoc/generating_patches.xml PRE-CREATION
> src/site/xdoc/index.xml PRE-CREATION
> src/site/xdoc/javadoc_modules.xml PRE-CREATION
> src/site/xdoc/pagerank.xml PRE-CREATION
> src/site/xdoc/presentations.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10365/diff/
>
>
> Testing
> -------
>
> Built the site.
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: Improve website for upcoming release
Posted by Alessandro Presta <al...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/#review18861
-----------------------------------------------------------
Looks much nicer!
Some random comments:
- I would try to reduce the amount of text on the landing page as much as possible: a few key sentences on the project (reference BSP, Pregel, Hadoop), how to build, and maybe a code snippet to show the vertex API. Everything else could probably be moved down or to other pages.
- The logo wastes quite a lot of space the way it's positioned (look at all the white space to its right). It would be better if it was side by side with the title or other text.
- There are some links to content that's probably outdated (e.g, the shortest paths example, the quick start guide). The menus could probably be better organized: we could separate user-oriented info (summary, license, mailing lists etc) from developer info (how to build the site, continuous integration, etc). The Modules section seems useless right now. License should probably link to the specific version. Do we even use all those Reports?
- The PageRank example currently has no code snippets. Also, in my opinion it's sufficient to call it PageRank (the Hello sounds a bit weird to me...).
- Alessandro Presta
On April 9, 2013, 7:28 a.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10365/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 7:28 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
>
> * Google +1 / Facebook like support
> * Google site search support
> * Modified ConfigurationUtils.java to support a non-munged profile
> * Updated incubator references
> * Added hudson location
> * Site now is a multi-module site instead of giraph-core only
> * Changed site layout to be more modern using the fluido skin
> * Added instructions on building the site
> * Added initial Hello, Page Rank example
> * Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
>
>
> This addresses bug GIRAPH-612.
> https://issues.apache.org/jira/browse/GIRAPH-612
>
>
> Diffs
> -----
>
> giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
> giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
> giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
> giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
> giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
> giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
> giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
> giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
> giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
> giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
> pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
> src/site/resources/css/site.css PRE-CREATION
> src/site/resources/images/ApacheGiraph.svg PRE-CREATION
> src/site/site.xml PRE-CREATION
> src/site/xdoc/build_site.xml PRE-CREATION
> src/site/xdoc/hello_pagerank.xml PRE-CREATION
> src/site/xdoc/index.xml PRE-CREATION
> src/site/xdoc/javadoc_modules.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10365/diff/
>
>
> Testing
> -------
>
> Built the site.
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: Improve website for upcoming release
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10365/
-----------------------------------------------------------
(Updated April 9, 2013, 7:28 a.m.)
Review request for giraph.
Description (updated)
-------
The website was in a horrible state (didn't even build). I fixed this and ported it to a modern skin (fluido).
* Google +1 / Facebook like support
* Google site search support
* Modified ConfigurationUtils.java to support a non-munged profile
* Updated incubator references
* Added hudson location
* Site now is a multi-module site instead of giraph-core only
* Changed site layout to be more modern using the fluido skin
* Added instructions on building the site
* Added initial Hello, Page Rank example
* Here's what the site looks like now http://apachegiraph.zapto.org/~aching/staging/
This addresses bug GIRAPH-612.
https://issues.apache.org/jira/browse/GIRAPH-612
Diffs
-----
giraph-accumulo/pom.xml fd1ee2beb170b8c8cc141c4c9f6821f78b2476c6
giraph-core/pom.xml 2f473ed764f94e61aa3bac50287424e64a13750d
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java 9ebe69301e2c42eb4d96c9916d4acb72ae795fa2
giraph-core/src/site/resources/css/site.css bd3e914cb7e3a13ee85e821fb2d73650077c4a03
giraph-core/src/site/resources/images/ApacheGiraph.svg 8c339c8fea13be1ed5d6280c61fe9271e636917f
giraph-core/src/site/site.xml 24b7ab25ed2103c6c96e68d7e73d64977a2851cb
giraph-core/src/site/xdoc/index.xml 2d496a229ae0db933c0a94047ec0c4dddfebabe4
giraph-examples/pom.xml 21e8ccfc20042b14fcd2059272522001d566e716
giraph-hbase/pom.xml 41b27e82aac24ded3ccb06eba527f5f8cf70bceb
giraph-hcatalog/pom.xml ee5710a67fcda5fdc5a77e9cdf4a2fc9e9722c88
giraph-hive/pom.xml 2f80165ff6ecd4f255f8c6e9cd3acdf07c872817
pom.xml 71467cdc1ef83ad835ab7522e6112e8c1389a772
src/site/resources/css/site.css PRE-CREATION
src/site/resources/images/ApacheGiraph.svg PRE-CREATION
src/site/site.xml PRE-CREATION
src/site/xdoc/build_site.xml PRE-CREATION
src/site/xdoc/hello_pagerank.xml PRE-CREATION
src/site/xdoc/index.xml PRE-CREATION
src/site/xdoc/javadoc_modules.xml PRE-CREATION
Diff: https://reviews.apache.org/r/10365/diff/
Testing
-------
Built the site.
Thanks,
Avery Ching