You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2023/04/16 13:11:45 UTC
[arrow] branch main updated: GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int` (#35120)
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 3ff3cc856f GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int` (#35120)
3ff3cc856f is described below
commit 3ff3cc856f47d76aae53c187789900b468c18a58
Author: Chunchun Ye <14...@users.noreply.github.com>
AuthorDate: Sun Apr 16 08:11:33 2023 -0500
GH-35118: [FlightSQL] Use `int32` to refer to 32-bit integers rather than `int` (#35120)
### Rationale for this change
The spec is inconsistent -- see details on #35118
### What changes are included in this PR?
Use `int32` to refer to 32-bit integers rather than `int`
### Are these changes tested?
No, only comments are changed
### Are there any user-facing changes?
This clarifies a small corner case in the document
* Closes: https://github.com/apache/arrow/issues/35118
* Closes: #35118
Authored-by: Chunchun <14...@users.noreply.github.com>
Signed-off-by: Andrew Lamb <an...@nerdnetworks.org>
---
format/FlightSql.proto | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/format/FlightSql.proto b/format/FlightSql.proto
index ad427fd809..650c67f24d 100644
--- a/format/FlightSql.proto
+++ b/format/FlightSql.proto
@@ -1271,7 +1271,7 @@ message CommandGetTableTypes {
* table_name: utf8 not null,
* column_name: utf8 not null,
* key_name: utf8,
- * key_sequence: int not null
+ * key_sequence: int32 not null
* >
* The returned data should be ordered by catalog_name, db_schema_name, table_name, key_name, then key_sequence.
*/
@@ -1321,7 +1321,7 @@ enum UpdateDeleteRules {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
- * key_sequence: int not null,
+ * key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,
@@ -1367,7 +1367,7 @@ message CommandGetExportedKeys {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
- * key_sequence: int not null,
+ * key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,
@@ -1420,7 +1420,7 @@ message CommandGetImportedKeys {
* fk_db_schema_name: utf8,
* fk_table_name: utf8 not null,
* fk_column_name: utf8 not null,
- * key_sequence: int not null,
+ * key_sequence: int32 not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint8 not null,