[whimsy] branch master updated: WHIMSY-141 Add sort to PMC member and committer tables

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new f7bf875  WHIMSY-141 Add sort to PMC member and committer tables
f7bf875 is described below

commit f7bf87588df982010fc10665966b8cee1a69d298
Author: Sebb <se...@apache.org>
AuthorDate: Tue Sep 12 14:12:32 2017 +0100

    WHIMSY-141 Add sort to PMC member and committer tables
---
 www/roster/views/pmc/committers.js.rb |  9 +++++++--
 www/roster/views/pmc/pmc.js.rb        | 13 +++++++++----
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/www/roster/views/pmc/committers.js.rb b/www/roster/views/pmc/committers.js.rb
index 3baee6c..16afd3f 100644
--- a/www/roster/views/pmc/committers.js.rb
+++ b/www/roster/views/pmc/committers.js.rb
@@ -15,12 +15,13 @@ class PMCCommitters < Vue
         _ 'Committers'
         _small ' (excluding PMC members above)'
       end
+      _p 'Click on column name to search'
       _table.table.table_hover do
         _thead do
           _tr do
             _th if @@auth
-            _th 'id'
-            _th 'public name'
+            _th 'id', data_sort: 'string'
+            _th.sorting_asc 'public name', data_sort: 'string-ins'
           end
         end
 
@@ -35,6 +36,10 @@ class PMCCommitters < Vue
     end
   end
 
+  def mounted()
+    jQuery('.table', $el).stupidtable()
+  end
+
   # compute list of committers
   def committers
     result = []
diff --git a/www/roster/views/pmc/pmc.js.rb b/www/roster/views/pmc/pmc.js.rb
index a3d4316..0b6a543 100644
--- a/www/roster/views/pmc/pmc.js.rb
+++ b/www/roster/views/pmc/pmc.js.rb
@@ -9,14 +9,15 @@ class PMCMembers < Vue
 
   def render
     _h2.pmc! 'PMC'
+    _p 'Click on column name to search'
     _table.table.table_hover do
       _thead do
         _tr do
           _th if @@auth
-          _th 'id'
-          _th 'public name'
-          _th 'starting date'
-          _th 'status - click cell for actions'
+          _th 'id', data_sort: 'string'
+          _th.sorting_asc 'public name', data_sort: 'string-ins'
+          _th 'starting date', data_sort: 'string'
+          _th 'status - click cell for actions', data_sort: 'string'
         end
       end
 
@@ -28,6 +29,10 @@ class PMCMembers < Vue
     end
   end
 
+  def mounted()
+    jQuery('.table', $el).stupidtable()
+  end
+
   def roster
     result = []
     

-- 
To stop receiving notification emails like this one, please contact
['"commits@whimsical.apache.org" <co...@whimsical.apache.org>'].