[GitHub] [incubator-mxnet] KexinFeng commented on pull request #20380: [BUGFIX] fix issue in elemwise_add

[GitBox <gi...@apache.org>]

KexinFeng commented on pull request #20380:
URL: https://github.com/apache/incubator-mxnet/pull/20380#issuecomment-877649848


   > Any news on this?
   > 
   > 
   > 
   > > This is unfortunately not a valid fix for the issue (and the fact that without static allocation everything works fine shows that) - the bug seems to lie rather inside the `CachedOp` and its handling of the static memory allocation. The `CloneGradient` method in the backward of `elemwise_add` is just a simple passing the input gradient data in both directions (vs copying it as the proposed `ElemwiseGradUseNone` does), which is the right thing to do.
   > 
   > 
   > 
   > So this is an inefficient workaround because it wastes some time copying the data? Can there be other shortcomings besides performance by using this fix? We really need this to work and we don't mind paying just a small performance drop while waiting for a proper fix.
   
   
   Hi, currently this fix can deal with your problem but fails other tests during the pull request. So it is still under investigation. It doesn't seem to me to cause inefficiency; it's just not valid yet. But maybe it can be a workaround 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org