You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 09:44:30 UTC

[GitHub] [orc] zhjwpku opened a new pull request, #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

zhjwpku opened a new pull request, #1370:
URL: https://github.com/apache/orc/pull/1370

   
   ### What changes were proposed in this pull request?
   
   remove whitespace before the scope resolution operator
   
   ### Why are the changes needed?
   
   though spaces are allowed before/after the scope resolution operator, but this
   
   is bad for the following case:
   
   `CompressionStrategy ::CompressionStrategy_SPEED`
   
   
   ### How was this patch tested?
   
   It doesn't introduce new features and passed all test cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku closed pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

Posted by GitBox <gi...@apache.org>.
zhjwpku closed pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator
URL: https://github.com/apache/orc/pull/1370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku commented on pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on PR #1370:
URL: https://github.com/apache/orc/pull/1370#issuecomment-1377083957

   > Unfortunately, I have not found a way to enforce it by clang format.
   
   Yeah, clang-format can remove the spaces after ::, but for the spaces before the ::, it always keeping one space.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

Posted by GitBox <gi...@apache.org>.
wgtmac commented on PR #1370:
URL: https://github.com/apache/orc/pull/1370#issuecomment-1377071303

   > scope resolution operator,
   
   Unfortunately, I have not found a way to enforce it by clang format.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku commented on pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on PR #1370:
URL: https://github.com/apache/orc/pull/1370#issuecomment-1377145275

   > If we are unable to enforce this programatically, is this worth for a JIRA and PR? Sorry, but I'd recommend to ignore this kind of instances in C++ in the future, @wgtmac and @zhjwpku .
   
   Sure, agree. PR closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1370: ORC-1354: [C++] remove whitespace before the scope resolution operator

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1370:
URL: https://github.com/apache/orc/pull/1370#issuecomment-1377133814

   If we are unable to enforce this, is this worth for a JIRA and PR?
   Sorry, but I'd recommend to ignore this kind of instances in C++ in the future, @wgtmac and @zhjwpku .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org