[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3642: [CARBONDATA-3725]fix concurrent creation of Materialized Views issue
URL: https://github.com/apache/carbondata/pull/3642#discussion_r387089006
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
 ##########
 @@ -271,24 +277,23 @@ public synchronized void unRegisterDataMapCatalog(DataMapSchema dataMapSchema) {
    */
   public synchronized DataMapCatalog getDataMapCatalog(
       DataMapProvider dataMapProvider,
-      String providerName) throws IOException {
+      String providerName,
+      boolean clearCatalogs) throws IOException {
 
 Review comment:
   @jackylk : This is ok, clear is just assigning to null and multiple function calls in concurrent scenario always better to avoid.
   However, initializeDataMapCatalogs can be optimized in the future with more testing. we have some duplicate code there to handle the concurrent scenario

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services