You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 07:30:38 UTC

[GitHub] [flink] zentol opened a new pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

zentol opened a new pull request #12211:
URL: https://github.com/apache/flink/pull/12211


   `initializePartitioner` returns a `FlinkKafkaPartitioner`, without any generic parameter, as a result of which the type of the Optional is not well-defined.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630228421


   @tillrohrmann That's fine with me, feel free to merge your commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630018919


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1696",
       "triggerID" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 439f4f136e73eebb6c424f7f706ab91655516ed3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1696) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630018919


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 439f4f136e73eebb6c424f7f706ab91655516ed3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630641268


   Merged via d0fc02839d2f3d99be2c6420758ab50fb4828bc3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #12211:
URL: https://github.com/apache/flink/pull/12211


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630018919


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1696",
       "triggerID" : "439f4f136e73eebb6c424f7f706ab91655516ed3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 439f4f136e73eebb6c424f7f706ab91655516ed3 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1696) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630000482


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 439f4f136e73eebb6c424f7f706ab91655516ed3 (Mon May 18 07:34:15 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630638234


   Ok, will merge my commit now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12211: [FLINK-17790][kafka] Fix JDK 11 compile error

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12211:
URL: https://github.com/apache/flink/pull/12211#issuecomment-630000482


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 439f4f136e73eebb6c424f7f706ab91655516ed3 (Fri Oct 16 10:49:51 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org