[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1620: ZOOKEEPER-4230: tmp is not configurable in zookeeper-contrib-rest

[GitBox <gi...@apache.org>]

arshadmohammad commented on a change in pull request #1620:
URL: https://github.com/apache/zookeeper/pull/1620#discussion_r589568318



##########
File path: zookeeper-contrib/zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/RestMain.java
##########
@@ -53,7 +53,7 @@ public void start() throws IOException {
        System.out.println("Starting grizzly ...");
 
        boolean useSSL = cfg.useSSL();
-       gws = new GrizzlyWebServer(cfg.getPort(), "/tmp/23cxv45345/2131xc2/", useSSL);
+       gws = new GrizzlyWebServer(cfg.getPort(), System.getProperty("java.io.tmpdir","/tmp") + "/23cxv45345/2131xc2/", useSSL);

Review comment:
       yes, seems functionality will change if directory is created dynamically. How someone will put web resources in that dynamically created directory. So lets not use createTempDirectory.
   
   What you say @eolivelli 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org