You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "parthchandra (via GitHub)" <gi...@apache.org> on 2024/02/22 17:35:38 UTC

[PR] feat: date and timestamp trunc with format array (#1438) [arrow-datafusion-comet]

parthchandra opened a new pull request, #94:
URL: https://github.com/apache/arrow-datafusion-comet/pull/94

   feat: date and timestamp trunc with format array
   
   ## Which issue does this PR close?
   
   Closes #93 
   
   ## Rationale for this change
   Compatibility with Spark
   
   ## What changes are included in this PR?
   Implements support for the `format` parameter to be an array.
   
   ## How are these changes tested?
   
   Adds additional unit tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: date and timestamp trunc with format array (#1438) [arrow-datafusion-comet]

Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #94:
URL: https://github.com/apache/arrow-datafusion-comet/pull/94#issuecomment-1960055749

   @viirya thank you for the approval (and review). Will wait for other comments and ci before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Date and timestamp trunc with format array [arrow-datafusion-comet]

Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #94:
URL: https://github.com/apache/arrow-datafusion-comet/pull/94#issuecomment-1960296946

   Merge, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Date and timestamp trunc with format array [arrow-datafusion-comet]

Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao merged PR #94:
URL: https://github.com/apache/arrow-datafusion-comet/pull/94


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org