You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by sa...@apache.org on 2015/09/23 11:55:45 UTC

[1/4] git commit: updated refs/heads/master to a601ae4

Repository: cloudstack
Updated Branches:
  refs/heads/master 2f7852bc5 -> a601ae445


Automation for multiple disk attachments to instance


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/7bcf8480
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/7bcf8480
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/7bcf8480

Branch: refs/heads/master
Commit: 7bcf84803cdbb4174fc38aee6b64efdc56d27a1f
Parents: 8fcc76e
Author: pavan018 <pa...@gmail.com>
Authored: Wed Aug 12 15:22:19 2015 +0530
Committer: pavan018 <pa...@gmail.com>
Committed: Thu Aug 13 11:39:05 2015 +0530

----------------------------------------------------------------------
 .../test_simultaneous_volume_attach.py          | 264 +++++++++++++++++++
 1 file changed, 264 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/7bcf8480/test/integration/component/test_simultaneous_volume_attach.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_simultaneous_volume_attach.py b/test/integration/component/test_simultaneous_volume_attach.py
new file mode 100644
index 0000000..0c7e308
--- /dev/null
+++ b/test/integration/component/test_simultaneous_volume_attach.py
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackAPI import *
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+from marvin.lib.utils import (cleanup_resources,
+                              validateList)
+from marvin.lib.base import (ServiceOffering,
+                             VirtualMachine,
+                             Account,
+                             Volume,
+                             DiskOffering,
+                             )
+from marvin.lib.common import (get_domain,
+                                get_zone,
+                                get_template,
+                                find_storage_pool_type)
+from marvin.codes import (
+    PASS,
+    FAILED,
+    JOB_FAILED,
+    JOB_CANCELLED,
+    JOB_SUCCEEDED
+)
+from nose.plugins.attrib import attr
+import time
+
+
+class TestMultipleVolumeAttach(cloudstackTestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        testClient = super(TestMultipleVolumeAttach, cls).getClsTestClient()
+        cls.apiclient = testClient.getApiClient()
+        cls.services = testClient.getParsedTestDataConfig()
+        cls._cleanup = []
+        # Get Zone, Domain and templates
+        cls.domain = get_domain(cls.apiclient)
+        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+        cls.services['mode'] = cls.zone.networktype
+        cls.hypervisor = testClient.getHypervisorInfo()
+        cls.invalidStoragePoolType = False
+        #for LXC if the storage pool of type 'rbd' ex: ceph is not available, skip the test
+        if cls.hypervisor.lower() == 'lxc':
+            if not find_storage_pool_type(cls.apiclient, storagetype='rbd'):
+                # RBD storage type is required for data volumes for LXC
+                cls.invalidStoragePoolType = True
+                return
+        cls.disk_offering = DiskOffering.create(
+                                    cls.apiclient,
+                                    cls.services["disk_offering"]
+                                    )
+
+        template = get_template(
+                            cls.apiclient,
+                            cls.zone.id,
+                            cls.services["ostype"]
+                            )
+        if template == FAILED:
+            assert False, "get_template() failed to return template with description %s" % cls.services["ostype"]
+
+        cls.services["domainid"] = cls.domain.id
+        cls.services["zoneid"] = cls.zone.id
+        cls.services["template"] = template.id
+        cls.services["diskofferingid"] = cls.disk_offering.id
+
+        # Create VMs, VMs etc
+        cls.account = Account.create(
+                            cls.apiclient,
+                            cls.services["account"],
+                            domainid=cls.domain.id
+                            )
+        cls.service_offering = ServiceOffering.create(
+                                            cls.apiclient,
+                                            cls.services["service_offering"]
+                                        )
+        cls.virtual_machine = VirtualMachine.create(
+                                    cls.apiclient,
+                                    cls.services,
+                                    accountid=cls.account.name,
+                                    domainid=cls.account.domainid,
+                                    serviceofferingid=cls.service_offering.id,
+                                    mode=cls.services["mode"]
+                                )
+
+        if cls.hypervisor.lower() == 'lxc' and cls.storage_pools.type.lower() != 'rbd':
+            raise unittest.SkipTest("Data Disk attach for NFS is not supported on LXC")
+        #Create volumes (data disks)
+        cls.volume1 = Volume.create(
+                                   cls.apiclient,
+                                   cls.services,
+                                   account=cls.account.name,
+                                   domainid=cls.account.domainid
+                                   )
+
+        cls.volume2 = Volume.create(
+                                   cls.apiclient,
+                                   cls.services,
+                                   account=cls.account.name,
+                                   domainid=cls.account.domainid
+                                   )
+
+        cls.volume3 = Volume.create(
+                                   cls.apiclient,
+                                   cls.services,
+                                   account=cls.account.name,
+                                   domainid=cls.account.domainid
+                                   )
+
+        cls.volume4 = Volume.create(
+                                   cls.apiclient,
+                                   cls.services,
+                                   account=cls.account.name,
+                                   domainid=cls.account.domainid
+                                   )
+        cls._cleanup = [
+                        cls.service_offering,
+                        cls.disk_offering,
+                        cls.account
+                        ]
+
+    @classmethod
+    def tearDownClass(cls):
+        try:
+            cleanup_resources(cls.apiclient, cls._cleanup)
+        except Exception as e:
+            raise Exception("Warning: Exception during cleanup : %s" % e)
+
+    def setUp(self):
+        self.apiClient = self.testClient.getApiClient()
+        self.dbclient = self.testClient.getDbConnection()
+        self.cleanup = []
+
+        if self.invalidStoragePoolType:
+            self.skipTest("Skipping test because valid storage pool not\
+                    available")
+
+    def tearDown(self):
+        cleanup_resources(self.apiClient, self.cleanup)
+        return
+
+    # Method to attach volume but will return immediately as an asynchronous task does.
+    def attach_volume(self, apiclient,virtualmachineid, volume):
+        """Attach volume to instance"""
+        cmd = attachVolume.attachVolumeCmd()
+        cmd.isAsync = "false"
+        cmd.id = volume.id
+        cmd.virtualmachineid = virtualmachineid
+        return apiclient.attachVolume(cmd)
+
+    # Method to check the volume attach async jobs' status
+    def query_async_job(self, apiclient, jobid):
+        """Query the status for Async Job"""
+        try:
+            asyncTimeout = 3600
+            cmd = queryAsyncJobResult.queryAsyncJobResultCmd()
+            cmd.jobid = jobid
+            timeout = asyncTimeout
+            async_response = FAILED
+            while timeout > 0:
+                async_response = apiclient.queryAsyncJobResult(cmd)
+                if async_response != FAILED:
+                    job_status = async_response.jobstatus
+                    if job_status in [JOB_CANCELLED,
+                                  JOB_SUCCEEDED]:
+                        break
+                    elif job_status == JOB_FAILED:
+                        raise Exception("Job failed: %s" \
+                                    % async_response)
+                time.sleep(5)
+                timeout -= 5
+                self.debug("=== JobId: %s is Still Processing, "
+                              "Will TimeOut in: %s ====" % (str(jobid),
+                                                           str(timeout)))
+            return async_response
+        except Exception as e:
+            self.debug("==== Exception Occurred for Job: %s ====" %
+                  str(e))
+            return FAILED
+
+    @attr(tags = ["advanced", "advancedns", "basic","bpk"], required_hardware="true")
+    def test_attach_multiple_volumes(self):
+        """Attach multiple Volumes simultaneously to a Running VM
+        """
+        # Validate the following
+        # 1. All data disks attached successfully without any exception
+
+        self.debug(
+                "Attaching volume (ID: %s) to VM (ID: %s)" % (
+                                                    self.volume1.id,
+                                                    self.virtual_machine.id
+                                                    ))
+        vol1_jobId = self.attach_volume(self.apiClient, self.virtual_machine.id,self.volume1)
+
+        self.debug(
+                "Attaching volume (ID: %s) to VM (ID: %s)" % (
+                                                    self.volume2.id,
+                                                    self.virtual_machine.id
+                                                    ))
+        vol2_jobId = self.attach_volume(self.apiClient,self.virtual_machine.id, self.volume2)
+
+        self.debug(
+                "Attaching volume (ID: %s) to VM (ID: %s)" % (
+                                                    self.volume3.id,
+                                                    self.virtual_machine.id
+                                                    ))
+        vol3_jobId = self.attach_volume(self.apiClient,self.virtual_machine.id, self.volume3)
+
+        self.debug(
+                "Attaching volume (ID: %s) to VM (ID: %s)" % (
+                                                    self.volume4.id,
+                                                    self.virtual_machine.id
+                                                    ))
+        vol4_jobId = self.attach_volume(self.apiClient,self.virtual_machine.id, self.volume4)
+
+        self.query_async_job(self.apiClient,vol1_jobId.jobid)
+        self.query_async_job(self.apiClient,vol2_jobId.jobid)
+        self.query_async_job(self.apiClient,vol3_jobId.jobid)
+        self.query_async_job(self.apiClient,vol4_jobId.jobid)
+
+        # List all the volumes attached to the instance. Includes even the Root disk.
+        list_volume_response = Volume.list(
+                                            self.apiClient,
+                                            virtualmachineid=self.virtual_machine.id,
+                                            account=self.account.name,
+                                            domainid=self.account.domainid
+                                          )
+        self.assertEqual(
+            validateList(list_volume_response)[0],
+            PASS,
+            "Check list response returns a valid list"
+        )
+
+        # Extract only the data disks attached to the instance.
+        data_disks_list = [ disk for disk in list_volume_response if disk.type == 'DATADISK']
+
+        self.assertEqual(
+            validateList(data_disks_list)[0],
+            PASS,
+            "Check data disk check returns a valid list"
+        )
+
+        self.assertEqual(
+                            len(data_disks_list),
+                            4,
+                            "All 4 data disks are not attached to VM Successfully"
+                            )
+
+        return
\ No newline at end of file


[4/4] git commit: updated refs/heads/master to a601ae4

Posted by sa...@apache.org.
Merge pull request #683 from pavanb018/multivol

CLOUDSTACK-8726 : Automation for Quickly attaching multiple data disks to a new VMAttach multiple Volumes simultaneously to a Running VM ... === TestName: test_attach_multiple_volumes | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 196.931s

OK

* pr/683:
  changed the testcase skip code into setup method
  Imparting changes mentioned by nitt10prashant
  Automation for multiple disk attachments to instance

Signed-off-by: sanjeev <sa...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a601ae44
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a601ae44
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a601ae44

Branch: refs/heads/master
Commit: a601ae445de14b3012c2518dde5614b1e42a26cf
Parents: 2f7852b 96b1a5c
Author: sanjeev <sa...@apache.org>
Authored: Wed Sep 23 15:23:18 2015 +0530
Committer: sanjeev <sa...@apache.org>
Committed: Wed Sep 23 15:23:27 2015 +0530

----------------------------------------------------------------------
 .../test_simultaneous_volume_attach.py          | 255 +++++++++++++++++++
 1 file changed, 255 insertions(+)
----------------------------------------------------------------------



[3/4] git commit: updated refs/heads/master to a601ae4

Posted by sa...@apache.org.
changed the testcase skip code into setup method


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/96b1a5ce
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/96b1a5ce
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/96b1a5ce

Branch: refs/heads/master
Commit: 96b1a5ced1b1db841269c5d7e3eff9b9f164bd64
Parents: a4829f4
Author: pavan018 <pa...@gmail.com>
Authored: Thu Aug 13 11:38:27 2015 +0530
Committer: pavan018 <pa...@gmail.com>
Committed: Thu Aug 13 11:39:06 2015 +0530

----------------------------------------------------------------------
 test/integration/component/test_simultaneous_volume_attach.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/96b1a5ce/test/integration/component/test_simultaneous_volume_attach.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_simultaneous_volume_attach.py b/test/integration/component/test_simultaneous_volume_attach.py
index 12f9677..7ccde9c 100644
--- a/test/integration/component/test_simultaneous_volume_attach.py
+++ b/test/integration/component/test_simultaneous_volume_attach.py
@@ -61,6 +61,7 @@ class TestMultipleVolumeAttach(cloudstackTestCase):
                 # RBD storage type is required for data volumes for LXC
                 cls.invalidStoragePoolType = True
                 return
+
         cls.disk_offering = DiskOffering.create(
                                     cls.apiclient,
                                     cls.services["disk_offering"]
@@ -98,8 +99,6 @@ class TestMultipleVolumeAttach(cloudstackTestCase):
                                     mode=cls.services["mode"]
                                 )
 
-        if cls.hypervisor.lower() == 'lxc' and cls.storage_pools.type.lower() != 'rbd':
-            raise unittest.SkipTest("Data Disk attach for NFS is not supported on LXC")
         #Create volumes (data disks)
         cls.volume1 = Volume.create(
                                    cls.apiclient,


[2/4] git commit: updated refs/heads/master to a601ae4

Posted by sa...@apache.org.
Imparting changes mentioned by nitt10prashant


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/a4829f4d
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/a4829f4d
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/a4829f4d

Branch: refs/heads/master
Commit: a4829f4d444c78e721ad105f47a8be8b04734fb8
Parents: 7bcf848
Author: pavan018 <pa...@gmail.com>
Authored: Wed Aug 12 16:17:02 2015 +0530
Committer: pavan018 <pa...@gmail.com>
Committed: Thu Aug 13 11:39:06 2015 +0530

----------------------------------------------------------------------
 .../component/test_simultaneous_volume_attach.py      | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/a4829f4d/test/integration/component/test_simultaneous_volume_attach.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_simultaneous_volume_attach.py b/test/integration/component/test_simultaneous_volume_attach.py
index 0c7e308..12f9677 100644
--- a/test/integration/component/test_simultaneous_volume_attach.py
+++ b/test/integration/component/test_simultaneous_volume_attach.py
@@ -193,7 +193,7 @@ class TestMultipleVolumeAttach(cloudstackTestCase):
                   str(e))
             return FAILED
 
-    @attr(tags = ["advanced", "advancedns", "basic","bpk"], required_hardware="true")
+    @attr(tags = ["advanced", "advancedns", "basic"], required_hardware="true")
     def test_attach_multiple_volumes(self):
         """Attach multiple Volumes simultaneously to a Running VM
         """
@@ -237,6 +237,7 @@ class TestMultipleVolumeAttach(cloudstackTestCase):
         list_volume_response = Volume.list(
                                             self.apiClient,
                                             virtualmachineid=self.virtual_machine.id,
+                                            type="DATADISK",
                                             account=self.account.name,
                                             domainid=self.account.domainid
                                           )
@@ -246,17 +247,8 @@ class TestMultipleVolumeAttach(cloudstackTestCase):
             "Check list response returns a valid list"
         )
 
-        # Extract only the data disks attached to the instance.
-        data_disks_list = [ disk for disk in list_volume_response if disk.type == 'DATADISK']
-
-        self.assertEqual(
-            validateList(data_disks_list)[0],
-            PASS,
-            "Check data disk check returns a valid list"
-        )
-
         self.assertEqual(
-                            len(data_disks_list),
+                            len(list_volume_response),
                             4,
                             "All 4 data disks are not attached to VM Successfully"
                             )