You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Aljoscha Krettek <al...@apache.org> on 2018/02/01 13:45:24 UTC
Re: drop scala....version from artifact ;)
I think it's not wise to remove the Scala suffix. When using the Flink Runner you have to make sure that the Scala version matches the Scala version of the Flink Cluster. And I think comparing the suffix of your flink-runner dependency and the suffix of your Flink dist is an easy way of doing that.
> On 31. Jan 2018, at 16:55, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> Hi Romain,
>
> AFAIR only Flink runner uses scala version in the artifactId.
>
> +1 for me.
>
> Regards
> JB
>
> On 01/31/2018 04:45 PM, Romain Manni-Bucau wrote:
>> Hi guys
>>
>> since beam supports a single version of runners why not dropping the scala
>> version from the artifactId?
>>
>> ATM upgrades are painful cause you upgrade beam version....+ runner artifactIds.
>>
>> wdyt?
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: drop scala....version from artifact ;)
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Flink, Gearpump, Spark, and GCE provisioning are affected by this "issue".
Dropping it if we never manage 2 versions is nicer for end users IMHO but
I'm fine keeping it. Just would like to ensure it is uniform accross the
whole projet.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau>
2018-02-01 14:58 GMT+01:00 Aljoscha Krettek <al...@apache.org>:
> I think Kafka IO doesn't have a transitive Scala dependency anymore
> because Kafka removed that from their client code a while ago.
>
> Best,
> Aljoscha
>
> > On 1. Feb 2018, at 14:48, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> >
> > I got your point Aljoscha. Flink runner is the only module using this
> suffix.
> >
> > Spark runner, Kafka IO, and others also have a scala dep but don't use
> the suffix.
> >
> > So, we have three options:
> > 1. We leave as it is right now
> > 2. We remove suffix from Flink runner
> > 3. We add suffix to other modules (Spark runner, Kafka IO, ...)
> >
> > Thoughts ?
> >
> > I'm OK to stay on 1 for now.
> >
> > Regards
> > JB
> >
> > On 02/01/2018 02:45 PM, Aljoscha Krettek wrote:
> >> I think it's not wise to remove the Scala suffix. When using the Flink
> Runner you have to make sure that the Scala version matches the Scala
> version of the Flink Cluster. And I think comparing the suffix of your
> flink-runner dependency and the suffix of your Flink dist is an easy way of
> doing that.
> >>
> >>
> >>> On 31. Jan 2018, at 16:55, Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
> >>>
> >>> Hi Romain,
> >>>
> >>> AFAIR only Flink runner uses scala version in the artifactId.
> >>>
> >>> +1 for me.
> >>>
> >>> Regards
> >>> JB
> >>>
> >>> On 01/31/2018 04:45 PM, Romain Manni-Bucau wrote:
> >>>> Hi guys
> >>>>
> >>>> since beam supports a single version of runners why not dropping the
> scala
> >>>> version from the artifactId?
> >>>>
> >>>> ATM upgrades are painful cause you upgrade beam version....+ runner
> artifactIds.
> >>>>
> >>>> wdyt?
> >>>>
> >>>> Romain Manni-Bucau
> >>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >>>> <https://rmannibucau.metawerx.net/> | Old Blog
> >>>> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> >>>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
> >>>
> >>> --
> >>> Jean-Baptiste Onofré
> >>> jbonofre@apache.org
> >>> http://blog.nanthrax.net
> >>> Talend - http://www.talend.com
> >>
> >
> > --
> > Jean-Baptiste Onofré
> > jbonofre@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
>
>
Re: drop scala....version from artifact ;)
Posted by Aljoscha Krettek <al...@apache.org>.
I think Kafka IO doesn't have a transitive Scala dependency anymore because Kafka removed that from their client code a while ago.
Best,
Aljoscha
> On 1. Feb 2018, at 14:48, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>
> I got your point Aljoscha. Flink runner is the only module using this suffix.
>
> Spark runner, Kafka IO, and others also have a scala dep but don't use the suffix.
>
> So, we have three options:
> 1. We leave as it is right now
> 2. We remove suffix from Flink runner
> 3. We add suffix to other modules (Spark runner, Kafka IO, ...)
>
> Thoughts ?
>
> I'm OK to stay on 1 for now.
>
> Regards
> JB
>
> On 02/01/2018 02:45 PM, Aljoscha Krettek wrote:
>> I think it's not wise to remove the Scala suffix. When using the Flink Runner you have to make sure that the Scala version matches the Scala version of the Flink Cluster. And I think comparing the suffix of your flink-runner dependency and the suffix of your Flink dist is an easy way of doing that.
>>
>>
>>> On 31. Jan 2018, at 16:55, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>>>
>>> Hi Romain,
>>>
>>> AFAIR only Flink runner uses scala version in the artifactId.
>>>
>>> +1 for me.
>>>
>>> Regards
>>> JB
>>>
>>> On 01/31/2018 04:45 PM, Romain Manni-Bucau wrote:
>>>> Hi guys
>>>>
>>>> since beam supports a single version of runners why not dropping the scala
>>>> version from the artifactId?
>>>>
>>>> ATM upgrades are painful cause you upgrade beam version....+ runner artifactIds.
>>>>
>>>> wdyt?
>>>>
>>>> Romain Manni-Bucau
>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
>>>
>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>
>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
Re: drop scala....version from artifact ;)
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
I got your point Aljoscha. Flink runner is the only module using this suffix.
Spark runner, Kafka IO, and others also have a scala dep but don't use the suffix.
So, we have three options:
1. We leave as it is right now
2. We remove suffix from Flink runner
3. We add suffix to other modules (Spark runner, Kafka IO, ...)
Thoughts ?
I'm OK to stay on 1 for now.
Regards
JB
On 02/01/2018 02:45 PM, Aljoscha Krettek wrote:
> I think it's not wise to remove the Scala suffix. When using the Flink Runner you have to make sure that the Scala version matches the Scala version of the Flink Cluster. And I think comparing the suffix of your flink-runner dependency and the suffix of your Flink dist is an easy way of doing that.
>
>
>> On 31. Jan 2018, at 16:55, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
>>
>> Hi Romain,
>>
>> AFAIR only Flink runner uses scala version in the artifactId.
>>
>> +1 for me.
>>
>> Regards
>> JB
>>
>> On 01/31/2018 04:45 PM, Romain Manni-Bucau wrote:
>>> Hi guys
>>>
>>> since beam supports a single version of runners why not dropping the scala
>>> version from the artifactId?
>>>
>>> ATM upgrades are painful cause you upgrade beam version....+ runner artifactIds.
>>>
>>> wdyt?
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
>>> LinkedIn <https://www.linkedin.com/in/rmannibucau>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com