You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "HonahX (via GitHub)" <gi...@apache.org> on 2025/01/24 19:46:10 UTC
[PR] [Preview Only] Fix Trino Getting-started Example [polaris]
HonahX opened a new pull request, #877:
URL: https://github.com/apache/polaris/pull/877
<!--
Possible security vulnerabilities: STOP here and contact security@apache.org instead!
Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Trino Getting-started example to use default authenticator [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #877:
URL: https://github.com/apache/polaris/pull/877#discussion_r1930238315
##########
getting-started/trino/README.md:
##########
@@ -24,7 +24,7 @@ This getting started guide provides a `docker-compose` file to set up [Trino](ht
## Build Polaris Image
Build Polaris Image while Docker is running
```
-./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
+./gradlew clean :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
Review Comment:
Sounds great, removed.
##########
getting-started/trino/README.md:
##########
@@ -24,7 +24,7 @@ This getting started guide provides a `docker-compose` file to set up [Trino](ht
## Build Polaris Image
Build Polaris Image while Docker is running
```
-./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
+./gradlew clean :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
Review Comment:
Sounds great! I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Trino Getting-started example to use default authenticator [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #877:
URL: https://github.com/apache/polaris/pull/877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Trino Getting-started example to use default authenticator [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #877:
URL: https://github.com/apache/polaris/pull/877#discussion_r1929843763
##########
getting-started/trino/README.md:
##########
@@ -24,7 +24,7 @@ This getting started guide provides a `docker-compose` file to set up [Trino](ht
## Build Polaris Image
Build Polaris Image while Docker is running
```
-./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
+./gradlew clean :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
Review Comment:
I'm not sure we need clean here. I mean, you will get exactly the same image, only it will be slower. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Trino Getting-started example to use default authenticator [polaris]
Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #877:
URL: https://github.com/apache/polaris/pull/877#discussion_r1929681902
##########
getting-started/trino/trino-config/catalog/iceberg.properties:
##########
@@ -21,7 +21,8 @@ connector.name=iceberg
iceberg.catalog.type=rest
iceberg.rest-catalog.uri=http://polaris:8181/api/catalog
iceberg.rest-catalog.security=OAUTH2
-iceberg.rest-catalog.oauth2.token=principal:root;realm:default-realm
+iceberg.rest-catalog.oauth2.credential=root:s3cr3t
Review Comment:
Make it consistent with other examples in #859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Trino Getting-started example to use default authenticator [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #877:
URL: https://github.com/apache/polaris/pull/877#discussion_r1929986877
##########
getting-started/trino/README.md:
##########
@@ -24,7 +24,7 @@ This getting started guide provides a `docker-compose` file to set up [Trino](ht
## Build Polaris Image
Build Polaris Image while Docker is running
```
-./gradlew :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
+./gradlew clean :polaris-quarkus-server:assemble -Dquarkus.container-image.build=true
Review Comment:
I think `clean` is not needed. The Spark example in #859 also with `clean`. Can we remove both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org