[jira] [Commented] (OLINGO-839) Invalid URL may return http status code 500 instead of 400

["Christian Amend (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061845#comment-15061845 ] 

Christian Amend commented on OLINGO-839:
----------------------------------------

Hi Gyula.

thanks for finding this and thanks for the patch. I had a look at the changes you made and this raised some questions. Why do you check for a specific String within the exception thext? This might not cover all exceptions which could happen during URI parsing. Could you please let me know what specifically causes the URL to be reparsed? I thought we prevented that in the exception wrapper already. 

I also saw the other patches you provided. Thank you for that. Since I am not very knowledgabel in the JPA context I think someone else will pick them up :)

Best Regards,
Christian

> Invalid URL may return http status code 500 instead of 400
> ----------------------------------------------------------
>
>                 Key: OLINGO-839
>                 URL: https://issues.apache.org/jira/browse/OLINGO-839
>             Project: Olingo
>          Issue Type: Bug
>          Components: odata2-core
>    Affects Versions: V2 2.0.5
>            Reporter: Gyula Árpád Tóth
>            Assignee: Christian Amend
>            Priority: Minor
>         Attachments: 0001-OLINGO-839-Broken-URL-response.patch
>
>
> Broken urls like: http://services.odata.org/OData/OData.svc/Suppliers?$filter=Address/City%20eq%20%27Redmond%2 should set the http status code to 400. In olingov2 the status code is set 500, because once the url parsing failed, in the ODataExceptionWrapper the url is parsed again and failed again, resulting in status code 500.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)