You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/30 18:06:09 UTC

[GitHub] [spark] srowen commented on a change in pull request #24500: [SPARK-27606][SQL] Deprecate 'extended' field in ExpressionDescription/ExpressionInfo

srowen commented on a change in pull request #24500: [SPARK-27606][SQL] Deprecate 'extended' field in ExpressionDescription/ExpressionInfo
URL: https://github.com/apache/spark/pull/24500#discussion_r279871516
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java
 ##########
 @@ -88,6 +88,12 @@
 @Retention(RetentionPolicy.RUNTIME)
 public @interface ExpressionDescription {
     String usage() default "";
+    /**
+     * @deprecated This field is deprecated as of Spark 3.0. Use {@link #arguments},
 
 Review comment:
   I don't have a strong opinion, but generally think it's fine to deprecate things we know we want to deprecate sooner than later. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org