[jira] [Closed] (FLINK-6530) Unclosed Response in DatadogHttpClient#validateApiKey()

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-6530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-6530.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.4.0
                   1.3.0

1.3: 81d520bbf9bffb6e37f4787ab4bc455f814c3b00
1.4: 50c88d5b14d58f138a3c95d31e3702f01c459e3f

> Unclosed Response in DatadogHttpClient#validateApiKey()
> -------------------------------------------------------
>
>                 Key: FLINK-6530
>                 URL: https://issues.apache.org/jira/browse/FLINK-6530
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.3.0, 1.4.0
>
>
> Here is related code:
> {code}
>     try {
>       Response response = client.newCall(r).execute();
>       if (!response.isSuccessful()) {
>         throw new IllegalArgumentException(
>           String.format("API key: %s is invalid", apiKey));
>       }
>     } catch(IOException e) {
>       throw new IllegalStateException("Failed contacting Datadog to validate API key", e);
> {code}
> If execute() throws exception, the Response instance would be left unclosed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)