You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/16 18:36:45 UTC
[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5297: Minimal Lexing Support for Go Language
matthiasblaesing commented on code in PR #5297:
URL: https://github.com/apache/netbeans/pull/5297#discussion_r1071494932
##########
nbbuild/licenses/CC-BY-4.0:
##########
@@ -0,0 +1,429 @@
+Attribution-ShareAlike 4.0 International
Review Comment:
This is `CC-BY-SA-4.0`. Given the wording of the license in the attribution clause, this needs an entry in the notice section.
##########
nbbuild/rat-exclusions.txt:
##########
@@ -220,6 +220,7 @@ javafx/javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**
java/jshell.support/src/org/netbeans/modules/jshell/resources/consoleExample.jsh
java/junit.ui/src/org/netbeans/modules/junit/ui/resources/*.template
ide/languages.diff/src/org/netbeans/modules/languages/diff/DiffExample.diff
+ide/languages.go/src/org/netbeans/modules/languages/go/*.go
Review Comment:
Please use the `licenseinfo.xml` to declare `GoExample.go` as `Apache-2.0-ASF`.
##########
ide/languages.go/nbproject/project.properties:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+javac.source=1.8
+
+# As of 2nd Jan 2023, we use the Grammar from:
+# https://github.com/antlr/grammars-v4/tree/4794c0c5371ce6b0711a306256f8f7706394ec6d/golang
+#
+golang.grammar.version=4794c0c5371ce6b0711a306256f8f7706394ec6d
Review Comment:
This is not needed or is it? But it reminds me, that parsers have the tendency to create incompatible code when the grammar is modified. So either `go.lang` should be a friend-only export or we must be willing to drop compatibility in the future (i.e. raise major version).
##########
ide/languages.go/licenseinfo.xml:
##########
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<licenseinfo>
+ <fileset>
+ <file>src/org/netbeans/modules/languages/go/resources/go-blue.png</file>
+ <license ref="CC-BY-4.0" />
Review Comment:
As written below I find this problematic. This is missing the required attribution from CC-BY-SA-4.0.
I assume the logo was taken from the go lang repository. Wikimedia Commons holds a PD licensed copy: https://commons.wikimedia.org/wiki/File:Go_Logo_Blue.svg
If that is not acceptable, I'm willing to open my graphic programm and enter the two letters and choose the "right" color.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists