[GitHub] [solr] risdenk commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1501:
URL: https://github.com/apache/solr/pull/1501#discussion_r1155113182


##########
solr/solrj/src/java/org/apache/solr/common/util/StrUtils.java:
##########
@@ -363,4 +366,16 @@ public static String formatString(String pattern, Object... args) {
   public static boolean isNullOrEmpty(String string) {
     return string == null || string.isEmpty();
   }
+
+  public static String stringFromReader(Reader inReader) throws IOException {
+    try (Reader reader = new BufferedReader(inReader)) {
+      char[] arr = new char[8 * 1024];
+      StringBuilder buffer = new StringBuilder();

Review Comment:
   thanks looks a lot nicer - fixed in b8e3fd33d327d0fd0c57ea226a4ea90764c3298f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org