[GitHub] [superset] zhaoyongjie commented on pull request #18045: feat(advanced analytics): support groupby in resample

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18045:
URL: https://github.com/apache/superset/pull/18045#issuecomment-1013095193


   IMO, we have to give every adhoc column a explicit and unique name. This
   name not only used in ‘alias’ in the sql, but also in pandas column.
   
   On Fri, Jan 14, 2022 at 20:43 Ville Brofeldt ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > superset-frontend/packages/superset-ui-chart-controls/src/operators/resampleOperator.ts
   > <https://github.com/apache/superset/pull/18045#discussion_r784813929>:
   >
   > > +    const groupby_columns = ensureIsArray(queryObject.columns).map(column => {
   > +      if (isPhysicalColumn(column)) {
   > +        return column;
   > +      }
   > +      return column.label;
   > +    });
   >
   > @zhaoyongjie <https://github.com/zhaoyongjie> btw I just noticed that
   > when creating two adhoc columns with *different* expressions where the
   > label is *unchanged*, the query only includes the first one:
   > [image: image]
   > <https://user-images.githubusercontent.com/33317356/149516917-31ecd51b-ec44-4d1f-9291-7114fe88ec86.png>
   > So we should perhaps assign the label in the popover, even just giving
   > them a unique serial id, like "My Column", "My Column (1)", ..., "My Column
   > (n)".
   >
   > Ping @kgabryje <https://github.com/kgabryje>
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/superset/pull/18045#discussion_r784813929>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAPMKUVPIAHNCREU4R5G7EDUWAK7BANCNFSM5L6TO4FQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   -- 
   
   Best regards,
   
   Yongjie
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org