You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/26 10:40:41 UTC
[GitHub] [solr] janhoy opened a new pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
janhoy opened a new pull request #369:
URL: https://github.com/apache/solr/pull/369
https://issues.apache.org/jira/browse/SOLR-15608
I took a stab at all the SolrClient classes and removed deprecated stuff, some of which had been deprecated since 7.x, other more recently in 8.x. Many places the `@Deprecated` annotation does not indicate version, so I have tried to inspect when it was added in git, to avoid removing deprecations that may have been introduced in 9.0 (but I think there are none).
I had to cut over lots of code and related tests to the new APIs. All tests pass.
PS: There's another JIRA about deprecating apache-httpclient in 8.x, but that will be a separate effort on the 8x branch only -- which may in turn result in removal of some of those classes in main, some of which are touched by this PR - but let's take one step at a time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a change in pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
Posted by GitBox <gi...@apache.org>.
epugh commented on a change in pull request #369:
URL: https://github.com/apache/solr/pull/369#discussion_r737687232
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java
##########
@@ -22,6 +22,9 @@
import org.apache.http.client.HttpClient;
import org.apache.solr.client.solrj.SolrClient;
+/**
+ * Retrieves cluster state via from Solr REST APIs
Review comment:
That's a good point @dsmiley and maybe if we were clearer on our language, we might have clearer discussions about the use of the word REST ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #369:
URL: https://github.com/apache/solr/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #369:
URL: https://github.com/apache/solr/pull/369#discussion_r737688176
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java
##########
@@ -22,6 +22,9 @@
import org.apache.http.client.HttpClient;
import org.apache.solr.client.solrj.SolrClient;
+/**
+ * Retrieves cluster state via from Solr REST APIs
Review comment:
Done 👍 (all within 5 minutes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #369:
URL: https://github.com/apache/solr/pull/369#issuecomment-953335179
Do we need more than the CHANGES line? It should go without saying that Java-level `@Deprecated` stuff can be removed in a major version, so no need to state that again in major-changes-in-solr-9 like we do for removed config-options and HTTP APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #369: SOLR-15608: Remove deprecated methods, classes and constructors from SolrJ
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #369:
URL: https://github.com/apache/solr/pull/369#discussion_r737406938
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClusterStateProvider.java
##########
@@ -22,6 +22,9 @@
import org.apache.http.client.HttpClient;
import org.apache.solr.client.solrj.SolrClient;
+/**
+ * Retrieves cluster state via from Solr REST APIs
Review comment:
It's an abuse of the word REST here. `?action=CLUSTERSTATUS` is not RESTful. Yes, this is an old debate but I'm old enough to have lived through this :-). Please don't add REST here; I suggest "Solr HTTP APIs". Some parts of Solr, however, it's a reasonable characterization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org