You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2026/05/12 18:55:15 UTC

[PR] docs: updating arrays_zip output field naming [datafusion]

timsaucer opened a new pull request, #22133:
URL: https://github.com/apache/datafusion/pull/22133

   ## Which issue does this PR close?
   
   No issue opened, but discovered regression in unit tests in datafusion-python during upgrading to `main`
   
   ## Rationale for this change
   
   Documentation only to let users know that they will need to update their field naming expectations.
   
   ## What changes are included in this PR?
   
   Upgrade guide document.
   
   ## Are these changes tested?
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on code in PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#discussion_r3229404002


##########
docs/source/library-user-guide/upgrading/54.0.0.md:
##########
@@ -557,6 +557,20 @@ are stored as `Arc<T>` so the map remains cheap to clone.
 - Custom `ParquetFileReaderFactory` implementations or other consumers that
   read `partitioned_file.extensions` and downcast manually.
 
+### `arrays_zip` struct field names changed
+
+The `arrays_zip` (and its alias `list_zip`) scalar function now names its
+output struct fields `"1"`, `"2"`, ..., `"n"` (1-indexed, matching DuckDB and
+Spark) instead of `c0`, `c1`, ..., `c{n-1}`.
+
+**Who is affected:**
+
+- Queries or downstream code that references the output struct fields by name
+  (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `'1'`, `'2'`,
+  etc.
+
+See [PR #21047](https://github.com/apache/datafusion/pull/21047) for details.

Review Comment:
   Thanks @timsaucer I think https://github.com/apache/datafusion/pull/20886 is the correct PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#issuecomment-4434336100

   > Thanks for catching it @timsaucer
   > 
   > Left one comment on the reference.
   
   Excellent. Thank you for the correction!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on code in PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#discussion_r3229404002


##########
docs/source/library-user-guide/upgrading/54.0.0.md:
##########
@@ -557,6 +557,20 @@ are stored as `Arc<T>` so the map remains cheap to clone.
 - Custom `ParquetFileReaderFactory` implementations or other consumers that
   read `partitioned_file.extensions` and downcast manually.
 
+### `arrays_zip` struct field names changed
+
+The `arrays_zip` (and its alias `list_zip`) scalar function now names its
+output struct fields `"1"`, `"2"`, ..., `"n"` (1-indexed, matching DuckDB and
+Spark) instead of `c0`, `c1`, ..., `c{n-1}`.
+
+**Who is affected:**
+
+- Queries or downstream code that references the output struct fields by name
+  (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `'1'`, `'2'`,
+  etc.
+
+See [PR #21047](https://github.com/apache/datafusion/pull/21047) for details.

Review Comment:
   ```suggestion
   See [PR #20886](https://github.com/apache/datafusion/pull/20886) for details.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #22133:
URL: https://github.com/apache/datafusion/pull/22133


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#discussion_r3229555518


##########
docs/source/library-user-guide/upgrading/54.0.0.md:
##########
@@ -557,6 +557,20 @@ are stored as `Arc<T>` so the map remains cheap to clone.
 - Custom `ParquetFileReaderFactory` implementations or other consumers that
   read `partitioned_file.extensions` and downcast manually.
 
+### `arrays_zip` struct field names changed
+
+The `arrays_zip` (and its alias `list_zip`) scalar function now names its
+output struct fields `"1"`, `"2"`, ..., `"n"` (1-indexed, matching DuckDB and
+Spark) instead of `c0`, `c1`, ..., `c{n-1}`.
+
+**Who is affected:**
+
+- Queries or downstream code that references the output struct fields by name
+  (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `'1'`, `'2'`,

Review Comment:
   ```suggestion
     (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `1`, `2`,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#issuecomment-4433755982

   FYI @hsiang-c as the author of the upstream PR this caused a unit test regression in datafusion-python so I think we should have this note in the upgrade guide.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "hsiang-c (via GitHub)" <gi...@apache.org>.
hsiang-c commented on PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#issuecomment-4434350507

   (nit) An update to the PR description if possible, not a must.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] docs: updating arrays_zip output field naming [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #22133:
URL: https://github.com/apache/datafusion/pull/22133#discussion_r3229559308


##########
docs/source/library-user-guide/upgrading/54.0.0.md:
##########
@@ -557,6 +557,20 @@ are stored as `Arc<T>` so the map remains cheap to clone.
 - Custom `ParquetFileReaderFactory` implementations or other consumers that
   read `partitioned_file.extensions` and downcast manually.
 
+### `arrays_zip` struct field names changed
+
+The `arrays_zip` (and its alias `list_zip`) scalar function now names its
+output struct fields `"1"`, `"2"`, ..., `"n"` (1-indexed, matching DuckDB and
+Spark) instead of `c0`, `c1`, ..., `c{n-1}`.
+
+**Who is affected:**
+
+- Queries or downstream code that references the output struct fields by name
+  (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `'1'`, `'2'`,
+  etc.

Review Comment:
   ```suggestion
     etc. Example `arrays_zip(a, b)[0]`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org