[GitHub] [spark] WweiL commented on a diff in pull request #42283: [SPARK-44433][PYTHON][CONNECT][SS][FOLLOWUP] Terminate listener process with `removeListener` and improvements

["WweiL (via GitHub)" <gi...@apache.org>]

WweiL commented on code in PR #42283:
URL: https://github.com/apache/spark/pull/42283#discussion_r1296289913


##########
python/pyspark/sql/tests/connect/streaming/test_parity_listener.py:
##########
@@ -76,6 +80,9 @@ def test_listener_events(self):
         finally:
             self.spark.streams.removeListener(test_listener)
 
+            # Remove again to verify this won't throw any error
+            self.spark.streams.removeListener(test_listener)

Review Comment:
   That test is not to ensure the worker is removed, it is to ensure no error will be thrown when `removeListener` is called twice on the same listener



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org