[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #656: MINIFI-1013 Used soci library.

[GitBox <gi...@apache.org>]

bakaid commented on a change in pull request #656: MINIFI-1013 Used soci library.
URL: https://github.com/apache/nifi-minifi-cpp/pull/656#discussion_r366981746
 
 

 ##########
 File path: extensions/sql/data/JSONSQLWriter.cpp
 ##########
 @@ -0,0 +1,101 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "JSONSQLWriter.h"
+#include "rapidjson/writer.h"
+#include "rapidjson/stringbuffer.h"
+#include "rapidjson/prettywriter.h"
+#include "Exception.h"
+#include "Utils.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace sql {
+
+JSONSQLWriter::JSONSQLWriter()
+  : jsonPayload_(rapidjson::kArrayType) {
+}
+
+JSONSQLWriter::~JSONSQLWriter() {}
+
+void JSONSQLWriter::beginProcessRow() {
+  jsonRow_ = rapidjson::kObjectType;
+}
+
+void JSONSQLWriter::endProcessRow() {
+  jsonPayload_.PushBack(jsonRow_, jsonPayload_.GetAllocator());
+}
+
+void JSONSQLWriter::processColumnName(const std::string& name) {}
+
+void JSONSQLWriter::processColumn(const std::string& name, const std::string& value) {
+  addToJSONRow(name, toJSONString(value));
+}
+
+void JSONSQLWriter::processColumn(const std::string& name, double value) {
+  addToJSONRow(name, rapidjson::Value().SetDouble(value));
 
 Review comment:
   These do not compile, because you are trying to bind a temporary to a non-const lvalue reference. This is not allowed by the standard, but for some reason it compiles on MSVC (but not with any other compiler).
   Since these are temporaries and `AddMember` ultimately moves out their contents, I suggest changing them to:
   ```
   addToJSONRow(name, std::move(rapidjson::Value().SetDouble(value)));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services