You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by JamesRTaylor <gi...@git.apache.org> on 2015/07/26 08:35:59 UTC

[GitHub] phoenix pull request: PHOENIX-2144 Implement JSON operators

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/101#discussion_r35489860
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java ---
    @@ -200,12 +224,12 @@ public Expression visitLeave(ComparisonParseNode node, List<Expression> children
             Expression lhsExpr = children.get(0);
             Expression rhsExpr = children.get(1);
             PDataType dataTypeOfLHSExpr = lhsExpr.getDataType();
    -        if (dataTypeOfLHSExpr != null && !dataTypeOfLHSExpr.isEqualitySupported()) {
    +        if (!(lhsExpr instanceof BaseJSONExpression)&& dataTypeOfLHSExpr != null && !dataTypeOfLHSExpr.isEqualitySupported()) {
    --- End diff --
    
    The visitLeave(ComparisonParseNode) method gets called when =, <, >, etc. comparison operators are used in an expression. I thought this wasn't valid for JSON?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---