You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "David Johnson (JIRA)" <no...@atlassian.com> on 2007/06/23 02:59:30 UTC
[Roller-JIRA] Created: (ROL-1458) Referrers macro not showing count
Referrers macro not showing count
---------------------------------
Key: ROL-1458
URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1458
Project: Roller
Issue Type: Bug
Components: Macros
Affects Versions: 3.1
Reporter: David Johnson
Assignee: David Johnson
Priority: Minor
Fix For: 3.1.1
>From Gary Kephart on the Roller mailing list:
> The Referer list shows up, but there's no count next to it like there
> was on Roller 1.0.
> How do I fix this?
And later:
> Found the answer to this. If you look in WEB-INF/velocity/weblog.vm,
> you'll see the macro "showReferrersList" defined. Within that macro, it
> references the boolean variable $includeHits. That variable is not found
> anywhere else, and so is permanently set to false. In Roller 1.0, it was
> a parameter to the macro. So I added it back in like so:
>
> #macro(showReferrersList $refs $max $maxWidth $includeHits)
>
> Then, you have to go to Preferences:Templates and edit your weblog file.
>
> For me, this was Gary's Weblog. In there, it calls the above macro, and
> you have to pass it in a value for $includeHits, like so:
>
> #showReferrersList($refs 30 20 true)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Roller-JIRA] Resolved: (ROL-1458) Referrers macro not showing
count
Posted by "David Johnson (JIRA)" <no...@atlassian.com>.
[ http://opensource.atlassian.com/projects/roller/browse/ROL-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Johnson resolved ROL-1458.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.0
FIxed in trunk (4.0) and 3.1 branch
> Referrers macro not showing count
> ---------------------------------
>
> Key: ROL-1458
> URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1458
> Project: Roller
> Issue Type: Bug
> Components: Macros
> Affects Versions: 3.1
> Reporter: David Johnson
> Assignee: David Johnson
> Priority: Minor
> Fix For: 3.1.1, 4.0
>
>
> From Gary Kephart on the Roller mailing list:
> > The Referer list shows up, but there's no count next to it like there
> > was on Roller 1.0.
> > How do I fix this?
> And later:
> > Found the answer to this. If you look in WEB-INF/velocity/weblog.vm,
> > you'll see the macro "showReferrersList" defined. Within that macro, it
> > references the boolean variable $includeHits. That variable is not found
> > anywhere else, and so is permanently set to false. In Roller 1.0, it was
> > a parameter to the macro. So I added it back in like so:
> >
> > #macro(showReferrersList $refs $max $maxWidth $includeHits)
> >
> > Then, you have to go to Preferences:Templates and edit your weblog file.
> >
> > For me, this was Gary's Weblog. In there, it calls the above macro, and
> > you have to pass it in a value for $includeHits, like so:
> >
> > #showReferrersList($refs 30 20 true)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[Roller-JIRA] Commented: (ROL-1458) Referrers macro not showing
count
Posted by "David Johnson (JIRA)" <no...@atlassian.com>.
[ http://opensource.atlassian.com/projects/roller/browse/ROL-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_13838 ]
David Johnson commented on ROL-1458:
------------------------------------
Added missing argument to macro.
Fixed in basic theme and in every theme that uses the the referrers macro.
In both trunk (4.0) and 3.1.1 branch.
> Referrers macro not showing count
> ---------------------------------
>
> Key: ROL-1458
> URL: http://opensource.atlassian.com/projects/roller/browse/ROL-1458
> Project: Roller
> Issue Type: Bug
> Components: Macros
> Affects Versions: 3.1
> Reporter: David Johnson
> Assignee: David Johnson
> Priority: Minor
> Fix For: 3.1.1
>
>
> From Gary Kephart on the Roller mailing list:
> > The Referer list shows up, but there's no count next to it like there
> > was on Roller 1.0.
> > How do I fix this?
> And later:
> > Found the answer to this. If you look in WEB-INF/velocity/weblog.vm,
> > you'll see the macro "showReferrersList" defined. Within that macro, it
> > references the boolean variable $includeHits. That variable is not found
> > anywhere else, and so is permanently set to false. In Roller 1.0, it was
> > a parameter to the macro. So I added it back in like so:
> >
> > #macro(showReferrersList $refs $max $maxWidth $includeHits)
> >
> > Then, you have to go to Preferences:Templates and edit your weblog file.
> >
> > For me, this was Gary's Weblog. In there, it calls the above macro, and
> > you have to pass it in a value for $includeHits, like so:
> >
> > #showReferrersList($refs 30 20 true)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/roller/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira