[GitHub] [tvm] Lunderberg commented on a change in pull request #8542: [UnitTests] Apply correct requires_gpu() pytest marks for parametrized target

[GitBox <gi...@apache.org>]

Lunderberg commented on a change in pull request #8542:
URL: https://github.com/apache/tvm/pull/8542#discussion_r677524817



##########
File path: python/tvm/testing.py
##########
@@ -795,15 +795,32 @@ def _auto_parametrize_target(metafunc):
 
     """
     if "target" in metafunc.fixturenames:
-        parametrized_args = [
-            arg.strip()
-            for mark in metafunc.definition.iter_markers("parametrize")
-            for arg in mark.args[0].split(",")
-        ]
-
-        if "target" not in parametrized_args:
-            # Check if the function is marked with either excluded or
-            # known failing targets.
+        for mark in metafunc.definition.iter_markers("parametrize"):

Review comment:
       No problem, and I can change that.  The loop-else reads as cleaner to me, even in the blog post's example, but having a consistent style with the rest of the TVM codebase is far more important so I'll avoid using them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org