[GitHub] flink pull request #2866: [FLINK-5101] Refactor CassandraConnectorITCase

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2866#discussion_r97309628
  
    --- Diff: flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java ---
    @@ -69,17 +87,27 @@ public void onFailure(Throwable t) {
     
     	@Override
     	public void invoke(IN value) throws Exception {
    -		if (exception != null) {
    -			throw new IOException("invoke() failed", exception);
    +		Throwable e = exception.get();
    +		if (e != null) {
    +			throw new IOException("Error while sending value.", e);
     		}
     		ListenableFuture<V> result = send(value);
    +		updatesPending.incrementAndGet();
     		Futures.addCallback(result, callback);
     	}
     
     	public abstract ListenableFuture<V> send(IN value);
     
     	@Override
     	public void close() {
    +		while (updatesPending.get() > 0) {
    +			synchronized (updatesPending) {
    +				try {
    +					updatesPending.wait();
    +				} catch (InterruptedException e) {
    +				}
    --- End diff --
    
    Probably better here even: Throw an exception, because closing is incomplete when interrupted (and cannot guarantee correctness)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---