You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/04 07:00:51 UTC
[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2454: [ISSUE #2368] Method calls equals on an enum instance
jonyangx opened a new pull request, #2454:
URL: https://github.com/apache/incubator-eventmesh/pull/2454
Fixes #2368 .
### Motivation
Method calls equals on an enum instance
### Modifications
refactor eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientGroupWrapper.java line 615 623, replace equals method with '=='.
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? ( not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2454: [ISSUE #2368] Method calls equals on an enum instance
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2454:
URL: https://github.com/apache/incubator-eventmesh/pull/2454#issuecomment-1336646013
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2454](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8df35fc) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/050281beaa691de9a7fe33a29198fea72801f5e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (050281b) will **decrease** coverage by `0.03%`.
> The diff coverage is `3.94%`.
> :exclamation: Current head 8df35fc differs from pull request most recent head 0ab1e26. Consider uploading reports for the commit 0ab1e26 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2454 +/- ##
============================================
- Coverage 11.81% 11.77% -0.04%
+ Complexity 905 901 -4
============================================
Files 469 469
Lines 27781 27792 +11
Branches 2991 3010 +19
============================================
- Hits 3281 3272 -9
- Misses 24204 24227 +23
+ Partials 296 293 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...core/protocol/grpc/consumer/EventMeshConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...untime/core/protocol/grpc/push/MessageHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL01lc3NhZ2VIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ime/core/protocol/grpc/push/StreamPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL1N0cmVhbVB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...me/core/protocol/grpc/push/WebhookPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL1dlYmhvb2tQdXNoUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ntime/core/protocol/grpc/service/ServiceUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9zZXJ2aWNlL1NlcnZpY2VVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../core/protocol/http/push/AsyncHTTPPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0FzeW5jSFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ocol/tcp/client/EventMeshTcpMessageDispatcher.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9FdmVudE1lc2hUY3BNZXNzYWdlRGlzcGF0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../protocol/tcp/client/group/ClientGroupWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9ncm91cC9DbGllbnRHcm91cFdyYXBwZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../core/protocol/tcp/client/EventMeshTcp2Client.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9FdmVudE1lc2hUY3AyQ2xpZW50LmphdmE=) | `1.58% <5.88%> (+0.04%)` | :arrow_up: |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `32.46% <66.66%> (-7.80%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2454/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2454: [ISSUE #2368] Method calls equals on an enum instance
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2454:
URL: https://github.com/apache/incubator-eventmesh/pull/2454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org