You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/19 15:28:38 UTC
[GitHub] [dubbo-go] cjphaha commented on a diff in pull request #1963: [WIP] Enhance ServiceDefinition in MetadataService
cjphaha commented on code in PR #1963:
URL: https://github.com/apache/dubbo-go/pull/1963#discussion_r924623162
##########
metadata/service/remote/service.go:
##########
@@ -109,7 +109,9 @@ func (s *MetadataService) PublishServiceDefinition(url *common.URL) error {
if common.RoleType(common.PROVIDER).Role() == url.GetParam(constant.SideKey, "") {
if len(interfaceName) > 0 && !isGeneric {
sv := common.ServiceMap.GetServiceByServiceKey(url.Protocol, url.ServiceKey())
- sd := definition.BuildServiceDefinition(*sv, url)
+ // sd := definition.BuildServiceDefinition(*sv, url)
+ // Waiting to be uncommented when passing sufficient tests
Review Comment:
The code commented out here can be deleted
##########
metadata/service/local/service.go:
##########
@@ -202,7 +202,9 @@ func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error {
isGeneric := url.GetParamBool(constant.GenericKey, false)
if len(interfaceName) > 0 && !isGeneric {
tmpService := common.ServiceMap.GetServiceByServiceKey(url.Protocol, url.ServiceKey())
- sd := definition.BuildServiceDefinition(*tmpService, url)
+ // sd := definition.BuildServiceDefinition(*tmpService, url)
+ // Waiting to be uncommented when passing sufficient tests
Review Comment:
The code commented out here can be deleted
##########
metadata/definition/definition.go:
##########
@@ -121,6 +122,54 @@ func BuildServiceDefinition(service common.Service, url *common.URL) *ServiceDef
return sd
}
+func BuildFullDefinition(service common.Service, url *common.URL) *FullServiceDefinition {
Review Comment:
Please add a comment above the function， such as
```go
// BuildFullDefinition ...
func BuildFullDefinition(service common.Service, url *common.URL)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org