[GitHub] spark pull request #16099: [SPARK-18665][SQL] set statement state to "ERROR"...

[BruceXu1991 <gi...@git.apache.org>]

Github user BruceXu1991 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16099#discussion_r116693874
  
    --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala ---
    @@ -241,6 +241,8 @@ private[hive] class SparkExecuteStatementOperation(
           dataTypes = result.queryExecution.analyzed.output.map(_.dataType).toArray
         } catch {
           case e: HiveSQLException =>
    +        HiveThriftServer2.listener.onStatementError(
    +          statementId, e.getMessage, SparkUtils.exceptionString(e))
    --- End diff --
    
    I tried your code. there seems have a bug.
    e.getMessage may get a null value, which may cause NPE in ThriftServerPage.errorMessageCell(detail)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org