You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Andrew McIntyre (JIRA)" <de...@db.apache.org> on 2006/08/17 07:54:13 UTC
[jira] Created: (DERBY-1709) Deprecate scripts in frameworks
directory
Deprecate scripts in frameworks directory
-----------------------------------------
Key: DERBY-1709
URL: http://issues.apache.org/jira/browse/DERBY-1709
Project: Derby
Issue Type: Improvement
Components: Demos/Scripts
Affects Versions: 10.2.0.0
Reporter: Andrew McIntyre
Fix For: 10.2.2.0
With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1709?page=comments#action_12456877 ]
Bryan Pendleton commented on DERBY-1709:
----------------------------------------
I have to say that derbyrun.jar is just so darn cool, that nowadays I never seem to use the scripts at all. I just point at derbyrun.jar and away I go! I still think it's nice to have the scripts, and I think that your ideas for deprecaiting the old scripts are fine. The other thing I thought you might do, if you haven't done so already, is to point a comment in the old scripts themsevles, saying that they are old and pointing to the new scripts.
But I think that the doc changes should consider just switching over to derbyrun.jar.
Vive derbyrun.jar!
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: http://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Fix For: 10.2.3.0
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre reassigned DERBY-1709:
--------------------------------------
Assignee: Andrew McIntyre
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: http://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470499 ]
Kristian Waagan commented on DERBY-1709:
----------------------------------------
I have read the text and briefly looked at the diff. I have not done a complete review.
My comments:
- a little noise due to missing newline in some files (a nit, editor "artifact")
- in frameworks.DEPRECATED:
a) Strange sentence?
"An alternative to using the set*CP scripts is to add derbyrun.jar from the Derby distribution to your classpath will put all of the Derby classes into your classpath."
b) Missing space: PROTOCOLcommand
c) A few long lines.
I tried the scripts on Solaris to confirm that the notice is displayed, and it is.
However, when not run from the directory where the scripts is located, the notice script is not found.
For UNIX this can easily be solved by using ". `dirname $0`/../../deprecated_notice.ksh". Don't know for Windows.
Is this worth fixing?
The script will of course still fail if it is moved (and the other one is not).
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre resolved DERBY-1709.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.3.0.0
Committed code changes to trunk with revision 507308 and 507312 and 10.2 with 507314. Marking resolved.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0, 10.3.0.0
>
> Attachments: derby-1709-code-v1.diff, derby-1709-code-v2.diff, DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1709?page=comments#action_12456696 ]
Andrew McIntyre commented on DERBY-1709:
----------------------------------------
So, I think the two main things remaining for this issue are marking the frameworks scripts in the tree as deprecated somehow and cleaning up references to the old scripts.
As far marking it deprecated, I thought that it might be best to have a DEPRECATED file at the top of the tree which could then be used for other purposes as well. The thing is, I'm not really sure what those other purposes would be. Deprecation in public interfaces to the engine, server, client, and tools would be in the javadoc. Would we ever need to deprecate a demo? :-)
So, the second option I thought of was to have a file, frameworks.DEPRECATED(.txt), that describes the scripts as deprecated and explains the usage of the new scripts that corresponds to each old script. Less intrusive than having a big, glaring DEPRECATED file at the top of the tree that really only applies to a small part of the distribution that isn't core functionality.
So, I'm currently leaning toward the second option, and will put that together tonight (or in the next few days, anyway) if I don't hear any objections. Opinions on this part?
The 10.2.1.6 release page and release notes indicate that the frameworks are deprecated and may be removed in a future release. So that is taken care of.
That leaves the docs. Found the following remaining references to the frameworks scripts in the docs:
adminguide/tadminapps811302.dita
adminguide/tadminappschangingyourclasspath.dita
adminguide/tadmincbdjhhfd.dita
adminguide/tadminconfigshuttingdownthenetworkserver.dita
adminguide/tadminconfigsysteminformation.dita
devguide/cdevstart16043.dita
devguide/cdevstart813142.dita
tools/ttoolsij11815.dita
tuning/ctundepth14326.dita
and one in the code tree:
java/demo/simple/example.html
I will also take care of these shortly as well.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: http://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Fix For: 10.2.3.0
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Kim Haase (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kim Haase updated DERBY-1709:
-----------------------------
Attachment: DERBY-1709-doc.zip
DERBY-1709-doc.diff
The documentation patch in the attached DERBY-1709-doc.diff and DERBY-1709-doc.zip fixes the few references to the frameworks directory scripts that will remain after the fixes to DERBY-1662.
src/adminguide/tadminconfigshuttingdownthenetworkserver.dita: changed /frameworks/NetworkServer/bin to /bin; fixed formatting of commands for consistency with DERBY-1662 changes.
src/devguide/cdevstart16043.dita: changed /frameworks to /bin and moved it up to maintain alphabetical order.
src/devguide/cdevstart813142.dita: changed /frameworks/embedded/bin to /bin.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff, DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre updated DERBY-1709:
-----------------------------------
Attachment: derby-1709-code-v1.diff
Attaching the changes for the code tree for this issue.
- Adds a new file to the top of the tree, frameworks.DEPRECATED.txt, which includes instructions on how to transition from using the old scripts to the new /bin scripts or to
derbyrun.jar. Also adds this file to the release-generating targets.
- Adds two simple scripts to the frameworks directory which print a deprecation warning when running the old scripts.
- Hooks the deprecation warning scripts into each script in the frameworks directory.
Please review. Will commit some time next week if there are no comments. I'll take care of the doc changes next week.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre closed DERBY-1709.
----------------------------------
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0, 10.3.0.0
>
> Attachments: derby-1709-code-v1.diff, derby-1709-code-v2.diff, DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew McIntyre updated DERBY-1709:
-----------------------------------
Attachment: derby-1709-code-v2.diff
Thanks for the review, Kristian!
I'm leaving the one DERBY_OPTS line long because there's no good cross-platform way to show it broken.
Not sure about the line endings, everything should be Unix line-endings in the text file, proper line-endings per platform in the various scripts. Thanks for mentioning it, though, I've added frameworks.DEPRECATED.txt to the list of files that get the line-ending treatment at release time.
Addressed the other comments as well. Got rid of the separate deprecation warning notice script and just put the warning into each file.
If there are no further comments, I will commit this in a day or two, and will verify line-endings on batch files are still correct after commit.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff, derby-1709-code-v2.diff, DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Andrew McIntyre (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471559 ]
Andrew McIntyre commented on DERBY-1709:
----------------------------------------
Thanks for the doc patch for this, Kim! I've committed it, along with a clarification to the mention of frameworks in the getting started guide, with revision 505121.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: https://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Assigned To: Andrew McIntyre
> Fix For: 10.2.3.0
>
> Attachments: derby-1709-code-v1.diff, derby-1709-code-v2.diff, DERBY-1709-doc.diff, DERBY-1709-doc.zip
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-1709) Deprecate scripts in frameworks
directory
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1709?page=all ]
Rick Hillegas updated DERBY-1709:
---------------------------------
Fix Version/s: 10.2.3.0
(was: 10.2.2.0)
Move to 10.2.3.0.
> Deprecate scripts in frameworks directory
> -----------------------------------------
>
> Key: DERBY-1709
> URL: http://issues.apache.org/jira/browse/DERBY-1709
> Project: Derby
> Issue Type: Improvement
> Components: Demos/Scripts
> Affects Versions: 10.2.1.6
> Reporter: Andrew McIntyre
> Fix For: 10.2.3.0
>
>
> With revision 432159, new scripts to be added to the -bin distribution as a part of DERBY-1032 were added to the distributions and snapshots. The old frameworks scripts should be marked as deprecated where appropriate in the documentation, readme files, and release pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira