[GitHub] [metron] justinleet commented on a change in pull request #1367: METRON-2022: Metron rest creates large number of connections to ZK which causes subsequent connection to zk fail

[GitBox <gi...@apache.org>]

justinleet commented on a change in pull request #1367: METRON-2022: Metron rest creates large number of connections to ZK which causes subsequent connection to zk fail
URL: https://github.com/apache/metron/pull/1367#discussion_r270644390
 
 

 ##########
 File path: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrMetaAlertDao.java
 ##########
 @@ -144,10 +144,11 @@ protected String getDefaultSourceTypeField() {
       }
     };
 
-    SolrClient solrClient = solrDao.getSolrClient(solrDao.getZkHosts());
+    SolrClient solrClient = solrDao.getSolrClient();
 
 Review comment:
   Well, as the original implementer, the technical reasoning is that I didn't know better. There's no compelling reason to leave it this way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services