You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/06 18:57:54 UTC
[GitHub] [spark] mengxr commented on a change in pull request #24816:
[SPARK-27968] ArrowEvalPythonExec.evaluate shouldn't eagerly read the first
row
mengxr commented on a change in pull request #24816: [SPARK-27968] ArrowEvalPythonExec.evaluate shouldn't eagerly read the first row
URL: https://github.com/apache/spark/pull/24816#discussion_r291326122
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala
##########
@@ -86,28 +86,11 @@ case class ArrowEvalPythonExec(udfs: Seq[PythonUDF], resultAttrs: Seq[Attribute]
sessionLocalTimeZone,
pythonRunnerConf).compute(batchIter, context.partitionId(), context)
- new Iterator[InternalRow] {
-
- private var currentIter = if (columnarBatchIter.hasNext) {
- val batch = columnarBatchIter.next()
Review comment:
This is the line that eagerly reads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org