You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2010/07/14 00:05:52 UTC
[jira] Created: (TAP5-1207) A form control component (such as
TextField) whose id is "id" can confuse client-side logic for the Form DOM
object
A form control component (such as TextField) whose id is "id" can confuse client-side logic for the Form DOM object
-------------------------------------------------------------------------------------------------------------------
Key: TAP5-1207
URL: https://issues.apache.org/jira/browse/TAP5-1207
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.0
Reporter: Howard M. Lewis Ship
Using Chrome's page inspector, I can see that the form's element has been rewritten, from:
<form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="form_3"
to:
<form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="[object HTMLInputElement]"><div class="" style="display: none; ">
....
ah, there is is:
<label for="id">ID</label>
<input class="normalField width60" size="5" id="id" name="id" type="text"></input><img id="id_icon" class="t-error-icon t-invisible" alt="" src="/assets/5.5.1_1/core/spacer.gif"/>
Having a form element with id "id" is bad!
Basically, each element of the form is mapped onto the Form as a property; so HTMLInputElement#id overwrites the id property of the Form (changing it from type string to type HTMLINputElement).
"id" and perhaps other names need to be added to the list of pre-reserved element ids inside the Form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1207) A form control component (such as
TextField) whose id is "id" can confuse client-side logic for the Form DOM
object
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1207.
--------------------------------------
Assignee: Howard M. Lewis Ship
Fix Version/s: 5.2.0
Resolution: Fixed
> A form control component (such as TextField) whose id is "id" can confuse client-side logic for the Form DOM object
> -------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1207
> URL: https://issues.apache.org/jira/browse/TAP5-1207
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
>
> Using Chrome's page inspector, I can see that the form's element has been rewritten, from:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="form_3"
> to:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="[object HTMLInputElement]"><div class="" style="display: none; ">
> ....
> ah, there is is:
> <label for="id">ID</label>
> <input class="normalField width60" size="5" id="id" name="id" type="text"></input><img id="id_icon" class="t-error-icon t-invisible" alt="" src="/assets/5.5.1_1/core/spacer.gif"/>
> Having a form element with id "id" is bad!
> Basically, each element of the form is mapped onto the Form as a property; so HTMLInputElement#id overwrites the id property of the Form (changing it from type string to type HTMLINputElement).
> "id" and perhaps other names need to be added to the list of pre-reserved element ids inside the Form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (TAP5-1207) A form control component (such as
TextField) whose id is "id" can confuse client-side logic for the Form DOM
object
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1207.
--------------------------------------
Assignee: Howard M. Lewis Ship
Fix Version/s: 5.2.0
Resolution: Fixed
> A form control component (such as TextField) whose id is "id" can confuse client-side logic for the Form DOM object
> -------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1207
> URL: https://issues.apache.org/jira/browse/TAP5-1207
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
>
> Using Chrome's page inspector, I can see that the form's element has been rewritten, from:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="form_3"
> to:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="[object HTMLInputElement]"><div class="" style="display: none; ">
> ....
> ah, there is is:
> <label for="id">ID</label>
> <input class="normalField width60" size="5" id="id" name="id" type="text"></input><img id="id_icon" class="t-error-icon t-invisible" alt="" src="/assets/5.5.1_1/core/spacer.gif"/>
> Having a form element with id "id" is bad!
> Basically, each element of the form is mapped onto the Form as a property; so HTMLInputElement#id overwrites the id property of the Form (changing it from type string to type HTMLINputElement).
> "id" and perhaps other names need to be added to the list of pre-reserved element ids inside the Form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1207) A form control component (such as
TextField) whose id is "id" can confuse client-side logic for the Form DOM
object
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888427#action_12888427 ]
Hudson commented on TAP5-1207:
------------------------------
Integrated in tapestry-5.2-freestyle #153 (See [http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/153/])
> A form control component (such as TextField) whose id is "id" can confuse client-side logic for the Form DOM object
> -------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1207
> URL: https://issues.apache.org/jira/browse/TAP5-1207
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
>
> Using Chrome's page inspector, I can see that the form's element has been rewritten, from:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="form_3"
> to:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="[object HTMLInputElement]"><div class="" style="display: none; ">
> ....
> ah, there is is:
> <label for="id">ID</label>
> <input class="normalField width60" size="5" id="id" name="id" type="text"></input><img id="id_icon" class="t-error-icon t-invisible" alt="" src="/assets/5.5.1_1/core/spacer.gif"/>
> Having a form element with id "id" is bad!
> Basically, each element of the form is mapped onto the Form as a property; so HTMLInputElement#id overwrites the id property of the Form (changing it from type string to type HTMLINputElement).
> "id" and perhaps other names need to be added to the list of pre-reserved element ids inside the Form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-1207) A form control component (such as
TextField) whose id is "id" can confuse client-side logic for the Form DOM
object
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888427#action_12888427 ]
Hudson commented on TAP5-1207:
------------------------------
Integrated in tapestry-5.2-freestyle #153 (See [http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/153/])
> A form control component (such as TextField) whose id is "id" can confuse client-side logic for the Form DOM object
> -------------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-1207
> URL: https://issues.apache.org/jira/browse/TAP5-1207
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.0
> Reporter: Howard M. Lewis Ship
> Assignee: Howard M. Lewis Ship
> Fix For: 5.2.0
>
>
> Using Chrome's page inspector, I can see that the form's element has been rewritten, from:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="form_3"
> to:
> <form class="margin3-5-5" onsubmit="javascript:return Tapestry.waitForPage(event);" action="/t5/widendev/searchadmin.removedoc.form" method="post" id="[object HTMLInputElement]"><div class="" style="display: none; ">
> ....
> ah, there is is:
> <label for="id">ID</label>
> <input class="normalField width60" size="5" id="id" name="id" type="text"></input><img id="id_icon" class="t-error-icon t-invisible" alt="" src="/assets/5.5.1_1/core/spacer.gif"/>
> Having a form element with id "id" is bad!
> Basically, each element of the form is mapped onto the Form as a property; so HTMLInputElement#id overwrites the id property of the Form (changing it from type string to type HTMLINputElement).
> "id" and perhaps other names need to be added to the list of pre-reserved element ids inside the Form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.