[jira] [Commented] (KAFKA-105) switch to using slf4j

["Jay Kreps (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085802#comment-13085802 ] 

Jay Kreps commented on KAFKA-105:
---------------------------------

For my part I have always felt that since everyone uses log4j, a wrapper around that was simply a bridge too far. The inline arguments are nice, but for some reason it only extends to 2 arguments and more than that allocates an array (as varargs would). I could go either way on this.

Another approach would be to just use String.format and omit the Logger.isDebugEnabled check.

> switch to using slf4j
> ---------------------
>
>                 Key: KAFKA-105
>                 URL: https://issues.apache.org/jira/browse/KAFKA-105
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Chris Burroughs
>            Assignee: Chris Burroughs
>
> Breaking out discussion from KAFKA-96.  
> slf4j has a cleaner (and faster) way of not logging: http://www.slf4j.org/faq.html#logging_performance that avoid both the redundant if's and string con-catting.  slf4j is just an api, we would still use log4j for the actual logging in the standalone server.  This also makes it easier on downstream projects who are not using log4j.  The downside is that java logging is notoriously complicated, and now we would have two logging frameworks that can break.
> Discussion from other projects; ZOOKEEPER-850, SOLR-560 HBASE-2608, CASSANDRA-625, THRIFT-558

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira