You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by michalklempa <gi...@git.apache.org> on 2016/10/25 08:26:50 UTC
[GitHub] nifi pull request #1159: Nifi-1069 fix init status exit code and restart
GitHub user michalklempa opened a pull request:
https://github.com/apache/nifi/pull/1159
Nifi-1069 fix init status exit code and restart
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ y ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ y ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ y ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ no ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ y ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ no ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michalklempa/nifi NIFI-1069_fix_init_status_exit_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1159
----
commit 460da679ed66e6d7ba1c93b06d5660f2d7a0a70b
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-10-04T12:25:49Z
Fixes NIFI-1069 init script status exit code 3 when not running, 0 when running
commit 5f90cb714dc48264e0f863ce864ac41ddb93556c
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-10-17T18:57:43Z
Resoving comment https://github.com/apache/nifi/pull/1093#discussion_r82104883
commit 5e35fe7596d35e10685de23f0aa16cefa0ee0062
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-10-25T08:21:52Z
Resolving comment https://github.com/apache/nifi/pull/1093#issuecomment-255769027 and the reopening of NIFI-1069 by https://issues.apache.org/jira/browse/NIFI-1069?focusedCommentId=15602308&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15602308
commit a3a84a152cff5adbe091b4c5ad0f2018f4344346
Author: Michal Klempa <mi...@gmail.com>
Date: 2016-10-25T08:25:05Z
Merge branch 'master' into NIFI-1069_fix_init_status_exit_code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1159: Nifi-1069 fix init status exit code and restart
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1159
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1159: Nifi-1069 fix init status exit code and restart
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1159
+1
Visually verified code and did a checkstyle build. Ran the nifi.sh commands and verified each worked as expected. Thanks @michalklempa, I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1159: Nifi-1069 fix init status exit code and restart
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---