You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/07/28 17:16:43 UTC
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18795
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Update compression libraries zlib, zstd, and snappy to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
- snappy 1.1.8 to 1.1.9
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
---
M buildall.sh
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/95/18795/1
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18795
to look at the new patch set (#3).
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Update compression libraries zlib, zstd, and snappy to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
- snappy 1.1.8 to 1.1.9
Skips building tests and benchmarks for Snappy because we don't use them
and Snappy switched to including them via git submodules, which aren't
packaged in the release.
Testing: `./build.sh zlib 1.2.12 snappy 1.1.9 zstd 1.5.2` completed
successfully on Ubuntu 20.04.
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
---
M build.sh
M buildall.sh
M source/snappy/build.sh
3 files changed, 14 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/95/18795/3
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 4:
Build was successful.
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Aug 2022 16:02:42 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18795
to look at the new patch set (#2).
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Update compression libraries zlib, zstd, and snappy to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
- snappy 1.1.8 to 1.1.9
Skips building tests and benchmarks for Snappy because we don't use them
and Snappy switched to including them via git submodules, which aren't
packaged in the release.
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
---
M build.sh
M buildall.sh
M source/snappy/build.sh
3 files changed, 14 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/95/18795/2
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5: Code-Review+2
This looks great
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:17:53 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:25:31 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 1:
What kind of testing should I do on this? Run a build locally?
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Jul 2022 17:43:34 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
Patch Set 4:
Build: https://master-03.jenkins.cloudera.com/view/Impala/view/Toolchain%20build/job/impala-toolchain-c7-package-build/197/
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 21:13:41 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
IMPALA-11458: Update zlib and zstd
Update compression libraries zlib and zstd to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Reviewed-on: http://gerrit.cloudera.org:8080/18795
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M build.sh
M buildall.sh
2 files changed, 10 insertions(+), 8 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib, zstd, snappy
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18795
to look at the new patch set (#4).
Change subject: IMPALA-11458: Update zlib, zstd, snappy
......................................................................
IMPALA-11458: Update zlib, zstd, snappy
Update compression libraries zlib, zstd, and snappy to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
- snappy 1.1.8 to 1.1.9
Skips building tests and benchmarks for Snappy because we don't use them
and Snappy switched to including them via git submodules, which aren't
packaged in the release.
Testing: `./build.sh zlib 1.2.12 snappy 1.1.9 zstd 1.5.2` completed
successfully on Ubuntu 20.04.
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
---
M build.sh
M buildall.sh
M source/snappy/build.sh
3 files changed, 18 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/95/18795/4
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18795
to look at the new patch set (#5).
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
IMPALA-11458: Update zlib and zstd
Update compression libraries zlib and zstd to latest versions:
- zlib 1.2.11 to 1.2.12
- zstd 1.4.9 to 1.5.2
Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
---
M build.sh
M buildall.sh
2 files changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/95/18795/5
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5:
Build without Snappy should start soon at https://master-03.jenkins.cloudera.com/view/Impala/view/Toolchain%20build/job/impala-toolchain-c7-package-build/198
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 17:43:57 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11458: Update zlib and zstd
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18795 )
Change subject: IMPALA-11458: Update zlib and zstd
......................................................................
Patch Set 5:
Thanks for putting this together, this looks good.
When we are merging the Impala change, I will also merge this one.
--
To view, visit http://gerrit.cloudera.org:8080/18795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e63cbd0c41e51f7b164a5356d3842a524569e9
Gerrit-Change-Number: 18795
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 23:18:45 +0000
Gerrit-HasComments: No